From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura
	packages.
Date: Tue, 07 Jul 2015 15:59:36 -0400
Message-ID: <87d20320yf.fsf@netris.org>
References: <87twtgicz4.fsf@gmail.com> <87zj380zxg.fsf@netris.org>
	<87io9vj28o.fsf@gmail.com> <87r3oj24sh.fsf@netris.org>
	<87d203ixcj.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1ZCZ26-0003Fj-DU
	for guix-devel@gnu.org; Tue, 07 Jul 2015 15:59:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1ZCZ23-0005sm-7f
	for guix-devel@gnu.org; Tue, 07 Jul 2015 15:59:58 -0400
Received: from world.peace.net ([50.252.239.5]:35865)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1ZCZ23-0005RF-3n
	for guix-devel@gnu.org; Tue, 07 Jul 2015 15:59:55 -0400
In-Reply-To: <87d203ixcj.fsf@gmail.com> (Alex Kost's message of "Tue, 07 Jul
	2015 22:25:32 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> writes:

> Mark H Weaver (2015-07-07 21:36 +0300) wrote:
>
>> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
>> index 82e8c88..6cdc846 100644
>> --- a/gnu/packages/pdf.scm
>> +++ b/gnu/packages/pdf.scm
>> @@ -172,8 +172,9 @@
>>      (build-system gnu-build-system)
>>      (arguments
>>       `(#:make-flags
>> -       `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> -          "PLUGINDIR=/lib/zathura" "CC=gcc")
>> +       `(,(string-append "PREFIX=" %output)
>> +         ,(string-append "PLUGINDIR=" %output "/lib/zathura")
>> +         "CC=gcc")
>
> As you change the whole clause anyway, wouldn't it be more good-looking
> to remove those "`" / "," and just use "list" instead?:
>
>           (list (string-append "PREFIX=" %output)
>                 (string-append "PLUGINDIR=" %output "/lib/zathura")
>                 "CC=gcc")

Agreed.  Pushed with this change.

    Thanks!
      Mark