* [PATCH] gnu: Add lxappearance.
@ 2015-07-12 14:21 Mathieu Lirzin
2015-07-13 8:35 ` Alex Kost
0 siblings, 1 reply; 8+ messages in thread
From: Mathieu Lirzin @ 2015-07-12 14:21 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: 0001-gnu-Add-lxappearance.patch --]
[-- Type: text/x-diff, Size: 3106 bytes --]
From bbb9a32ded0c047fa50413afe8e2c6b50f89a8ee Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@openmailbox.org>
Date: Sat, 11 Jul 2015 08:25:14 +0200
Subject: [PATCH] gnu: Add lxappearance.
* gnu/packages/lxde.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
gnu-system.am | 1 +
gnu/packages/lxde.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
create mode 100644 gnu/packages/lxde.scm
diff --git a/gnu-system.am b/gnu-system.am
index d6369b5..3ffa66a 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -192,6 +192,7 @@ GNU_SYSTEM_MODULES = \
gnu/packages/lsh.scm \
gnu/packages/lsof.scm \
gnu/packages/lua.scm \
+ gnu/packages/lxde.scm \
gnu/packages/lxqt.scm \
gnu/packages/lynx.scm \
gnu/packages/m4.scm \
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
new file mode 100644
index 0000000..5498f16
--- /dev/null
+++ b/gnu/packages/lxde.scm
@@ -0,0 +1,51 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lxde)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix download)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix packages))
+
+(define-public lxappearance
+ (package
+ (name "lxappearance")
+ (version "0.6.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "mirror://sourceforge/projects/lxde/files/LXAppearance/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1phnv1b2jdj2vlibjyc9z01izcf3k5zxj8glsaf0i3vh77zqmqq9"))))
+ (build-system gnu-build-system)
+ (native-inputs `(("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("gtk+" ,gtk+-2)))
+ (synopsis "LXDE GTK+ theme switcher")
+ (description
+ "LXAppearance is a desktop-independent GTK+ theme switcher able to change
+themes, icons, and fonts used by GTK+ applications.")
+ (home-page "http://lxde.org")
+ (license license:gpl2+)))
+
+;;; lxde.scm ends here
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-12 14:21 [PATCH] gnu: Add lxappearance Mathieu Lirzin
@ 2015-07-13 8:35 ` Alex Kost
2015-07-15 19:40 ` Mathieu Lirzin
0 siblings, 1 reply; 8+ messages in thread
From: Alex Kost @ 2015-07-13 8:35 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel
Mathieu Lirzin (2015-07-12 17:21 +0300) wrote:
[...]
> +(define-public lxappearance
> + (package
> + (name "lxappearance")
> + (version "0.6.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://sourceforge/projects/lxde/files/LXAppearance/"
I think it should be:
> + "mirror://sourceforge/project/lxde/LXAppearance/"
guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
gives some html file. Otherwise it looks good to me.
--
Alex
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-13 8:35 ` Alex Kost
@ 2015-07-15 19:40 ` Mathieu Lirzin
2015-07-15 21:37 ` Ludovic Courtès
2015-07-16 16:41 ` Mark H Weaver
0 siblings, 2 replies; 8+ messages in thread
From: Mathieu Lirzin @ 2015-07-15 19:40 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Alex Kost <alezost@gmail.com> writes:
> I think it should be:
>> + "mirror://sourceforge/project/lxde/LXAppearance/"
>
> guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
>
> gives some html file. Otherwise it looks good to me.
fixed!
One last question: I've used "LXDE" and "LXAppearance" because it's the
most common way to write them and LXDE is a acronym for "Lightweight X11
Desktop Environment". But Since we use the name "Gnome" (which is a
acronym), I wonder if we shouldn't use "Lxde" and "Lxappearance"
likewise.
--
Mathieu Lirzin
[-- Attachment #2: 0001-gnu-Add-lxappearance.patch --]
[-- Type: text/x-diff, Size: 3088 bytes --]
From 6f27db9f084a938f055787c06aaad3bb61ee449f Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@openmailbox.org>
Date: Sat, 11 Jul 2015 08:25:14 +0200
Subject: [PATCH] gnu: Add lxappearance.
* gnu/packages/lxde.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
gnu-system.am | 1 +
gnu/packages/lxde.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 50 insertions(+)
create mode 100644 gnu/packages/lxde.scm
diff --git a/gnu-system.am b/gnu-system.am
index fc6517c..368c30e 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -193,6 +193,7 @@ GNU_SYSTEM_MODULES = \
gnu/packages/lsh.scm \
gnu/packages/lsof.scm \
gnu/packages/lua.scm \
+ gnu/packages/lxde.scm \
gnu/packages/lxqt.scm \
gnu/packages/lynx.scm \
gnu/packages/m4.scm \
diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
new file mode 100644
index 0000000..cf837f5
--- /dev/null
+++ b/gnu/packages/lxde.scm
@@ -0,0 +1,49 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lxde)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix download)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix packages))
+
+(define-public lxappearance
+ (package
+ (name "lxappearance")
+ (version "0.6.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/project/lxde"
+ "LXAppearance/" name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1phnv1b2jdj2vlibjyc9z01izcf3k5zxj8glsaf0i3vh77zqmqq9"))))
+ (build-system gnu-build-system)
+ (inputs `(("gtk+" ,gtk+-2)))
+ (native-inputs `(("intltool" ,intltool)
+ ("pkg-config" ,pkg-config)))
+ (synopsis "LXDE GTK+ theme switcher")
+ (description "LXAppearance is a desktop-independent GTK+ theme switcher
+able to change themes, icons, and fonts used by GTK+ applications.")
+ (home-page "http://lxde.org")
+ (license license:gpl2+)))
+
+;;; lxde.scm ends here
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-15 19:40 ` Mathieu Lirzin
@ 2015-07-15 21:37 ` Ludovic Courtès
2015-07-16 16:41 ` Mark H Weaver
1 sibling, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2015-07-15 21:37 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel, Alex Kost
Mathieu Lirzin <mthl@openmailbox.org> skribis:
> One last question: I've used "LXDE" and "LXAppearance" because it's the
> most common way to write them and LXDE is a acronym for "Lightweight X11
> Desktop Environment". But Since we use the name "Gnome" (which is a
> acronym), I wonder if we shouldn't use "Lxde" and "Lxappearance"
> likewise.
It’s a mistake: the real name is “GNOME”. In general I think we should
use the spelling and case that upstream uses, so “LXDE” in that case.
> From 6f27db9f084a938f055787c06aaad3bb61ee449f Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Sat, 11 Jul 2015 08:25:14 +0200
> Subject: [PATCH] gnu: Add lxappearance.
>
> * gnu/packages/lxde.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
Also LGTM. :-)
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-15 19:40 ` Mathieu Lirzin
2015-07-15 21:37 ` Ludovic Courtès
@ 2015-07-16 16:41 ` Mark H Weaver
2015-07-16 18:26 ` Alex Kost
1 sibling, 1 reply; 8+ messages in thread
From: Mark H Weaver @ 2015-07-16 16:41 UTC (permalink / raw)
To: Mathieu Lirzin; +Cc: guix-devel, Alex Kost
Mathieu Lirzin <mthl@openmailbox.org> writes:
> Alex Kost <alezost@gmail.com> writes:
>
>> I think it should be:
>>> + "mirror://sourceforge/project/lxde/LXAppearance/"
>>
>> guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
>>
>> gives some html file. Otherwise it looks good to me.
>
> fixed!
The lxappearance builds are failing on Hydra, because the hash of the
downloaded source doesn't match the one in the package description:
http://hydra.gnu.org/eval/105500#tabs-new
http://hydra.gnu.org/build/588561
http://hydra.gnu.org/build/588561/nixlog/1/raw
Can you look into it?
Mark
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-16 16:41 ` Mark H Weaver
@ 2015-07-16 18:26 ` Alex Kost
2015-07-16 19:37 ` Mathieu Lirzin
2015-07-19 11:19 ` Mathieu Lirzin
0 siblings, 2 replies; 8+ messages in thread
From: Alex Kost @ 2015-07-16 18:26 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
Mark H Weaver (2015-07-16 19:41 +0300) wrote:
> Mathieu Lirzin <mthl@openmailbox.org> writes:
>
>> Alex Kost <alezost@gmail.com> writes:
>>
>>> I think it should be:
>>>> + "mirror://sourceforge/project/lxde/LXAppearance/"
>>>
>>> guix download "mirror://sourceforge/projects/lxde/files/LXAppearance/lxappearance-0.6.1.tar.xz"
>>>
>>> gives some html file. Otherwise it looks good to me.
>>
>> fixed!
>
> The lxappearance builds are failing on Hydra, because the hash of the
> downloaded source doesn't match the one in the package description:
>
> http://hydra.gnu.org/eval/105500#tabs-new
> http://hydra.gnu.org/build/588561
> http://hydra.gnu.org/build/588561/nixlog/1/raw
>
> Can you look into it?
It looks like there are problems with "sourceforge" itself currently.
I've tried to download several sources from it and every time I got an
html with the following contents instead:
[-- Attachment #2: sf.htm --]
[-- Type: text/html, Size: 639 bytes --]
[-- Attachment #3: Type: text/plain, Size: 68 bytes --]
So Mathieu's LXDE patches can't be checked right now :-(
--
Alex
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-16 18:26 ` Alex Kost
@ 2015-07-16 19:37 ` Mathieu Lirzin
2015-07-19 11:19 ` Mathieu Lirzin
1 sibling, 0 replies; 8+ messages in thread
From: Mathieu Lirzin @ 2015-07-16 19:37 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
Alex Kost <alezost@gmail.com> writes:
> So Mathieu's LXDE patches can't be checked right now :-(
Thanks for looking into it. There is a missing '/' too. I will send a fix
when sourceforge will work again.
Sorry for the mistake, I will be more careful next time.
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gnu: Add lxappearance.
2015-07-16 18:26 ` Alex Kost
2015-07-16 19:37 ` Mathieu Lirzin
@ 2015-07-19 11:19 ` Mathieu Lirzin
1 sibling, 0 replies; 8+ messages in thread
From: Mathieu Lirzin @ 2015-07-19 11:19 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
Fixed in commit 3ab98da1bd91a6d211475a18ba628180071b1a35.
--
Mathieu Lirzin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-07-19 11:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-12 14:21 [PATCH] gnu: Add lxappearance Mathieu Lirzin
2015-07-13 8:35 ` Alex Kost
2015-07-15 19:40 ` Mathieu Lirzin
2015-07-15 21:37 ` Ludovic Courtès
2015-07-16 16:41 ` Mark H Weaver
2015-07-16 18:26 ` Alex Kost
2015-07-16 19:37 ` Mathieu Lirzin
2015-07-19 11:19 ` Mathieu Lirzin
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.