Re: [PATCH v2 3/7] gnu: Allow OS configurations to add PAM session modules

[ludo@gnu.org (Ludovic Courtès)]

Andy Wingo <wingo@pobox.com> skribis:

> * gnu/services/base.scm (mingetty-service):
> * gnu/services/xorg.scm (slim-service):
> * gnu/services/ssh.scm (lsh-service):
> * gnu/system/linux.scm (unix-pam-service, base-pam-services): Add
>   #:additional-session-modules keyword argument.

I wonder if we really need #:additional-session-modules passed around.

My first suggestion would be to do ‘unix-pam-service’ or
‘base-pam-services’ in the OS declaration along these lines:

  (operating-system
    ;; ...
    (pam-services (map (lambda (service)
                         (pam-service
                           (inherit service)
                           (session (cons ...))))
                       (base-pam-services))))

But maybe that turned out to be inconvenient?  If so, perhaps we could
solve it by introducing helper procedures, like
‘add-pam-service-session’ or something?

Or am I missing something?  :-)

BTW, I realize we should rename (gnu system linux) to (gnu system pam)
and then document it in the manual.

Thanks,
Ludo’.