Re: [PATCH] Add Frescobaldi.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> First off: as this depends on Lilypond, and Lilypond uses Ghostscript to
> convert Postscript files to PDF, and this feature is broken until we
> update fontconfig to 2.11.94, one of the core features of Frescobaldi
> (rendering a score with Lilypond) isn’t actually working right now.

OK.

> AFAIK a patch to update fontconfig was submitted for the core-updates
> branch already.

There’s no such thing in ‘core-updates’.  However, one could set a
‘fontconfig-update’ branch and update Fontconfig and possibly related
libraries.  We could merge it in ‘master’ more quickly than
‘core-updates’.

> Frescobaldi needs poppler-qt4, a library that is built by poppler when
> Qt4 is found at build time.  I created a variant of the poppler package
> because I don’t want to add an unnecessary indirect dependency on Qt4
> for every package using poppler.

Yes, sounds good.

> From 98b7a6b8b5ccbc2b4648838830612e148c96d995 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 26 Aug 2015 23:22:29 +0200
> Subject: [PATCH 1/4] gnu: Add poppler-qt4.
>
> * gnu/packages/pdf.scm (poppler-qt4): New variable.

LGTM.

> From 37adcb501ef4a706b881f30530dfa23e8bd8d785 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 26 Aug 2015 23:23:31 +0200
> Subject: [PATCH 2/4] gnu: Add python-poppler-qt4.
>
> * gnu/packages/pdf.scm (python-poppler-qt4): New variable.

[...]

> +    (native-inputs
> +     `(("qt-4" ,qt-4)

Native?  If it’s for one of the binaries, such as ‘qmake’, please
mention it in a margin comment.

> +    (synopsis "Python bindings for libpoppler-qt4")

“Poppler-Qt4” maybe?

> +    (description
> +     "This package provides Python bindings for the Poppler Qt4 interface
> +library.")

“... for the Qt4 interface of the Poppler PDF rendering library.”
So that at least “PDF” shows up in the description.

OK with these changes.

> From 9cd29d58de90bee0d1b7fc929af84687bbfd4556 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 26 Aug 2015 23:24:16 +0200
> Subject: [PATCH 3/4] gnu: Add python-ly.
>
> * gnu/packages/python.scm (python-ly): New variable.

LGTM.

> From 34817062b868ea60d087788fd6040daf799165fd Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 26 Aug 2015 23:25:31 +0200
> Subject: [PATCH 4/4] gnu: Add frescobaldi.
>
> * gnu/packages/music.scm (frescobaldi): New variable.

[...]

> +    (home-page "http://www.frescobaldi.org/")
> +    (synopsis "LilyPond sheet music text editor")
> +    (description
> +     "Frescobaldi is a LilyPond sheet music text editor with syntax
> +highlighting and automatic completion.")

Would be nice to mention a couple of features, like: “Among other
things, it can render scores next to the source, can capture input from
MIDI or read MusicXML and ABC files, has a MIDI player for
proof-listening, and includes a documentation browser.”

OK with this change.

Thanks!

Ludo’.