From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add Frescobaldi. Date: Mon, 31 Aug 2015 22:32:40 +0200 Message-ID: <87d1y342s7.fsf@mdc-berlin.de> References: <876141n31i.fsf@elephly.net> <87d1y3aci9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWVl7-0003x9-Q1 for guix-devel@gnu.org; Mon, 31 Aug 2015 16:32:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWVl3-0008PD-Nl for guix-devel@gnu.org; Mon, 31 Aug 2015 16:32:53 -0400 In-Reply-To: <87d1y3aci9.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel Ludovic Court=C3=A8s writes: >> AFAIK a patch to update fontconfig was submitted for the core-updates >> branch already. > > There=E2=80=99s no such thing in =E2=80=98core-updates=E2=80=99. Howev= er, one could set a > =E2=80=98fontconfig-update=E2=80=99 branch and update Fontconfig and po= ssibly related > libraries. We could merge it in =E2=80=98master=E2=80=99 more quickly = than > =E2=80=98core-updates=E2=80=99. The patch I was referring to has been submitted here, but apparently it hasn=E2=80=99t been committed yet: http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00225.html >> * gnu/packages/pdf.scm (python-poppler-qt4): New variable. > > [...] > >> + (native-inputs >> + `(("qt-4" ,qt-4) > > Native? If it=E2=80=99s for one of the binaries, such as =E2=80=98qmak= e=E2=80=99, please > mention it in a margin comment. Oh, that was a mistake and isn=E2=80=99t actually needed. I removed it. (That=E2=80=99s an embarrassingly big input to forget about.) >> + (synopsis "Python bindings for libpoppler-qt4") > > =E2=80=9CPoppler-Qt4=E2=80=9D maybe? Okay. >> + (description >> + "This package provides Python bindings for the Poppler Qt4 inter= face >> +library.") > > =E2=80=9C... for the Qt4 interface of the Poppler PDF rendering library= .=E2=80=9D > So that at least =E2=80=9CPDF=E2=80=9D shows up in the description. > > OK with these changes. Okay. >> * gnu/packages/music.scm (frescobaldi): New variable. > > [...] > >> + (home-page "http://www.frescobaldi.org/") >> + (synopsis "LilyPond sheet music text editor") >> + (description >> + "Frescobaldi is a LilyPond sheet music text editor with syntax >> +highlighting and automatic completion.") > > Would be nice to mention a couple of features, like: =E2=80=9CAmong oth= er > things, it can render scores next to the source, can capture input from > MIDI or read MusicXML and ABC files, has a MIDI player for > proof-listening, and includes a documentation browser.=E2=80=9D > > OK with this change. I worked in the suggested changes and pushed. Thanks a lot for the review! ~~ Ricardo