From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: bpswm, sxhkd: New packages.
Date: Sat, 10 Oct 2015 12:45:48 +0300
Message-ID: <87d1wnrr8z.fsf@gmail.com>
References: <1444398678-21079-1-git-send-email-elisp.vim@gmail.com>
	<1444398678-21079-2-git-send-email-elisp.vim@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55333)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1Zkqio-000577-JB
	for guix-devel@gnu.org; Sat, 10 Oct 2015 05:45:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1Zkqin-0000wY-HG
	for guix-devel@gnu.org; Sat, 10 Oct 2015 05:45:46 -0400
Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:34313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1Zkqin-0000vd-As
	for guix-devel@gnu.org; Sat, 10 Oct 2015 05:45:45 -0400
Received: by lbbwt4 with SMTP id wt4so102916959lbb.1
	for <guix-devel@gnu.org>; Sat, 10 Oct 2015 02:45:44 -0700 (PDT)
In-Reply-To: <1444398678-21079-2-git-send-email-elisp.vim@gmail.com> (rws's
	message of "Sat, 10 Oct 2015 00:51:18 +1100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: rws <elisp.vim@gmail.com>
Cc: guix-devel@gnu.org

Hello and thanks for contributing!

We prefer a separate patch per package, so please split this in two.
Also was it intended to use "rws" as the Author name?  If not, then
please configure your git to use a name you want.

rws (2015-10-09 16:51 +0300) wrote:

> * gnu/packages/wm.scm (bspwm): New package.
> * gnu/packages/xdisorg.scm (sxhkd): New package.

Our convention is to write "New variable" because the package recipes
are just Guile variables.

Also don't forget to add copyright lines for yourself to the beggining
of wm.scm and xdisorg.scm:

;;; Copyright =C2=A9 2015 ...

[...]
> +    (synopsis "Simple X hotkey daemon")
> +    (description "sxhkd is a simple X hotkey daemon with a powerful and
> +compact configuration syntax.")
> +    (license bsd-2)))

Unlike the previous package, here it should be (license license:bsd-2).
As you can see in (gnu packages xdisorg), (guix licenses) module is used
with "#:prefix license:".

The rest looks good to me.  Could you send the updated patches?  Thanks!

--=20
Alex