From: Alex Kost <alezost@gmail.com>
To: rws <elisp.vim@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: bpswm, sxhkd: New packages.
Date: Sat, 10 Oct 2015 12:45:48 +0300 [thread overview]
Message-ID: <87d1wnrr8z.fsf@gmail.com> (raw)
In-Reply-To: <1444398678-21079-2-git-send-email-elisp.vim@gmail.com> (rws's message of "Sat, 10 Oct 2015 00:51:18 +1100")
Hello and thanks for contributing!
We prefer a separate patch per package, so please split this in two.
Also was it intended to use "rws" as the Author name? If not, then
please configure your git to use a name you want.
rws (2015-10-09 16:51 +0300) wrote:
> * gnu/packages/wm.scm (bspwm): New package.
> * gnu/packages/xdisorg.scm (sxhkd): New package.
Our convention is to write "New variable" because the package recipes
are just Guile variables.
Also don't forget to add copyright lines for yourself to the beggining
of wm.scm and xdisorg.scm:
;;; Copyright © 2015 ...
[...]
> + (synopsis "Simple X hotkey daemon")
> + (description "sxhkd is a simple X hotkey daemon with a powerful and
> +compact configuration syntax.")
> + (license bsd-2)))
Unlike the previous package, here it should be (license license:bsd-2).
As you can see in (gnu packages xdisorg), (guix licenses) module is used
with "#:prefix license:".
The rest looks good to me. Could you send the updated patches? Thanks!
--
Alex
next prev parent reply other threads:[~2015-10-10 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 13:51 [PATCH] Add bspwm rws
2015-10-09 13:51 ` [PATCH] gnu: bpswm, sxhkd: New packages rws
2015-10-10 9:45 ` Alex Kost [this message]
2015-10-10 11:06 ` [PATCH 0/2] Add sxhkd and bspwm xd1le
2015-10-10 11:06 ` [PATCH 1/2] gnu: sxhkd: New variable xd1le
2015-10-10 11:06 ` [PATCH 2/2] gnu: bspwm: " xd1le
2015-10-11 8:19 ` [PATCH 0/2] Add sxhkd and bspwm Alex Kost
2015-10-11 8:54 ` Efraim Flashner
2015-10-16 16:57 ` Alex Kost
2015-10-17 0:51 ` RW. S
2015-10-10 9:45 ` [PATCH] Add bspwm Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1wnrr8z.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=elisp.vim@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.