From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] system: grub: Convert grub background using rsvg-convert Date: Sat, 17 Oct 2015 15:17:51 +0200 Message-ID: <87d1wdljls.fsf@gnu.org> References: <87egitx3r7.fsf@netris.org> <87twrkwhs9.fsf@gnu.org> <87zj17vnrm.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnRN0-0001Pa-7u for guix-devel@gnu.org; Sat, 17 Oct 2015 09:17:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnRMw-00061m-T1 for guix-devel@gnu.org; Sat, 17 Oct 2015 09:17:58 -0400 In-Reply-To: <87zj17vnrm.fsf@igalia.com> (Andy Wingo's message of "Mon, 31 Aug 2015 10:57:17 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andy Wingo Cc: guix-devel@gnu.org, Luis Felipe =?utf-8?Q?L=C3=B3pez?= Acevedo Andy Wingo skribis: > On Fri 28 Aug 2015 19:15, Luis Felipe L=C3=B3pez Acevedo writes: > >> Modifying the document background does not affect the design at all, >> because we are using the dark rectangle on top of it as the background >> of the image, so it doesn't matter what the background of the document >> is. >> >> Could it be that rsvg-convert is complaining about transparency in the >> page/document background and not about the transparency of the >> checkerboard pattern in the "Background" layer? Because it is not >> complaining about the transparency in the layer that contains the logo >> (which has transparency as well), is it? > > We could use guile-cairo / guile-rsvg to convert, fwiw. Better to do > that than to cause our graphics people to modify the image. > > (use-modules (rsvg) (cairo)) > > (define (->int x) (inexact->exact (ceiling x))) > > (define (render-to-png in-svg out-png) > (let ((svg (rsvg-handle-new-from-file in-svg))) > (call-with-values (lambda () (rsvg-handle-get-dimensions svg)) > (lambda (width height em ex) > (let* ((surf (cairo-image-surface-create 'argb32 > (->int width) > (->int height))) > (cr (cairo-create surf))) > (rsvg-handle-render-cairo svg cr) > (cairo-surface-flush surf) > (cairo-surface-write-to-png (cairo-get-target cr) out-png))))= )) FWIW I tried this (finally!) and this has the same problem as =E2=80=98rsvg-convert=E2=80=99 regarding the checkerboard pattern. So maybe we need to apply Felipe=E2=80=99s changes anyway? Thoughts? Ludo=E2=80=99.