From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: Add qtkeychain.
Date: Thu, 05 Nov 2015 22:28:42 +0100
Message-ID: <87d1vocf05.fsf@gnu.org>
References: <1446497399-30726-1-git-send-email-efraim@flashner.co.il>
	<1446497399-30726-2-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZuS5Q-0002UV-Lm
	for guix-devel@gnu.org; Thu, 05 Nov 2015 16:28:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZuS5M-0006Tx-Jy
	for guix-devel@gnu.org; Thu, 05 Nov 2015 16:28:48 -0500
In-Reply-To: <1446497399-30726-2-git-send-email-efraim@flashner.co.il> (Efraim
	Flashner's message of "Mon, 2 Nov 2015 22:49:58 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/qt.scm (qtkeychain): New variable.

[...]

> +       (modify-phases
> +         %standard-phases

=E2=80=98%standard-phases=E2=80=99 goes on the previous line.

> +         (add-before
> +          'configure 'set-qt-trans-dir
> +           (lambda _
> +             (substitute* "CMakeLists.txt"
> +              (("\\$\\{qt_translations_dir\\}")
> +                "${CMAKE_INSTALL_PREFIX}/share/qtkeychain/translations")=
))))))

Is Qt able to find translations installed there?  Is some environment
variable needed to tell it where to look for them?

> +    (synopsis "Qt API to store passwords")
> +    (description
> +      "QtKeychain is a Qt API to store passwords and other secret data
> +securely.  It will not store any data unencrypted unless explicitly requ=
ested.")

What about =E2=80=9Cservice=E2=80=9D or =E2=80=9Cservice and library=E2=80=
=9D rather than =E2=80=9CAPI=E2=80=9D?

Thanks,
Ludo=E2=80=99.