From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add BLESS Date: Fri, 06 Nov 2015 22:16:03 +0100 Message-ID: <87d1vmakx8.fsf@gnu.org> References: <2238503.mBpvBuW9qZ@myrada> <871tc3ym73.fsf@gmail.com> <87d1vm6gke.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuoMi-0002jM-N3 for guix-devel@gnu.org; Fri, 06 Nov 2015 16:16:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuoMg-0007Lb-2P for guix-devel@gnu.org; Fri, 06 Nov 2015 16:16:08 -0500 In-Reply-To: <87d1vm6gke.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Fri, 6 Nov 2015 21:03:45 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org, Alex Kost Ricardo Wurmus skribis: > Alex Kost writes: > >> Ricardo Wurmus (2015-11-06 17:28 +0300) wrote: >> >> [...] >>> I have taken your recipe and removed more bundled sources in a snippet. >>> There=E2=80=99s still bundled stuff that we should get rid of, most imp= ortantly >>> kmc, which brings its own executables. >>> >>> I also changed the description based on the paper; instead of patching >>> the Makefile I overwrite the make flags. >>> >>> Attached is a patch. Does this work for you? >>> What do others think about this patch? >> >> Oops, too late for the comment, but still: >> >> [...] >>> +(define-public bless >>> + (package >>> + (name "bless") >>> + (version "1p02") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append "mirror://sourceforge/bless-ec/bless= .v" >>> + version ".tgz")) >>> + (sha256 >>> + (base32 >>> + "0rm0gw2s18dqwzzpl3c2x1z05ni2v0xz5dmfk3d33j6g4cgrlrdd")) >> tabulation =E2=86=91 here >> >>> + (modules '((guix build utils))) >> and wrong indentation =E2=86=91 here > > Ah! I didn=E2=80=99t see this. (So embarrassing.) Heheh. :-) =E2=80=98guix lint=E2=80=99 should report tabs. > What would the correct commit message be to fix this? Will you fix > this? Whatever makes sense to you. Ludo=E2=80=99.