From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add BLESS Date: Fri, 6 Nov 2015 21:03:45 +0100 Message-ID: <87d1vm6gke.fsf@mdc-berlin.de> References: <2238503.mBpvBuW9qZ@myrada> <871tc3ym73.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZunEt-0002RB-4x for guix-devel@gnu.org; Fri, 06 Nov 2015 15:03:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZunEp-0003Aj-4K for guix-devel@gnu.org; Fri, 06 Nov 2015 15:03:59 -0500 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:48005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZunEo-0003Ab-R5 for guix-devel@gnu.org; Fri, 06 Nov 2015 15:03:55 -0500 In-Reply-To: <871tc3ym73.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost writes: > Ricardo Wurmus (2015-11-06 17:28 +0300) wrote: > > [...] >> I have taken your recipe and removed more bundled sources in a snippet= . >> There=E2=80=99s still bundled stuff that we should get rid of, most im= portantly >> kmc, which brings its own executables. >> >> I also changed the description based on the paper; instead of patching >> the Makefile I overwrite the make flags. >> >> Attached is a patch. Does this work for you? >> What do others think about this patch? > > Oops, too late for the comment, but still: > > [...] >> +(define-public bless >> + (package >> + (name "bless") >> + (version "1p02") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "mirror://sourceforge/bless-ec/bles= s.v" >> + version ".tgz")) >> + (sha256 >> + (base32 >> + "0rm0gw2s18dqwzzpl3c2x1z05ni2v0xz5dmfk3d33j6g4cgrlrdd")) > tabulation =E2=86=91 here > >> + (modules '((guix build utils))) > and wrong indentation =E2=86=91 here Ah! I didn=E2=80=99t see this. (So embarrassing.) In both cases it=E2=80=99s tabs. I copied this whole expression from the original attachment and it didn=E2=80=99t occur to me to check for tabs a= s it looked just right in my Emacs. What would the correct commit message be to fix this? Will you fix this? ~~ Ricardo