From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add BLESS
Date: Fri, 6 Nov 2015 21:03:45 +0100 [thread overview]
Message-ID: <87d1vm6gke.fsf@mdc-berlin.de> (raw)
In-Reply-To: <871tc3ym73.fsf@gmail.com>
Alex Kost <alezost@gmail.com> writes:
> Ricardo Wurmus (2015-11-06 17:28 +0300) wrote:
>
> [...]
>> I have taken your recipe and removed more bundled sources in a snippet.
>> There’s still bundled stuff that we should get rid of, most importantly
>> kmc, which brings its own executables.
>>
>> I also changed the description based on the paper; instead of patching
>> the Makefile I overwrite the make flags.
>>
>> Attached is a patch. Does this work for you?
>> What do others think about this patch?
>
> Oops, too late for the comment, but still:
>
> [...]
>> +(define-public bless
>> + (package
>> + (name "bless")
>> + (version "1p02")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append "mirror://sourceforge/bless-ec/bless.v"
>> + version ".tgz"))
>> + (sha256
>> + (base32
>> + "0rm0gw2s18dqwzzpl3c2x1z05ni2v0xz5dmfk3d33j6g4cgrlrdd"))
> tabulation ↑ here
>
>> + (modules '((guix build utils)))
> and wrong indentation ↑ here
Ah! I didn’t see this. (So embarrassing.)
In both cases it’s tabs. I copied this whole expression from the
original attachment and it didn’t occur to me to check for tabs as it
looked just right in my Emacs.
What would the correct commit message be to fix this? Will you fix
this?
~~ Ricardo
next prev parent reply other threads:[~2015-11-06 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 19:49 Bioinformatics package: Bless Diane Trout
2015-11-06 14:28 ` [PATCH] Add BLESS (was: Re: Bioinformatics package: Bless) Ricardo Wurmus
2015-11-06 15:12 ` [PATCH] Add BLESS Ludovic Courtès
2015-11-06 17:22 ` Ricardo Wurmus
2015-11-06 16:01 ` [PATCH] Add BLESS (was: Re: Bioinformatics package: Bless) Diane Trout
2015-11-06 19:14 ` [PATCH] Add BLESS Alex Kost
2015-11-06 20:03 ` Ricardo Wurmus [this message]
2015-11-06 21:16 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1vm6gke.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.