Re: [PATCH] Add ApaptiveSparsity.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From b9ef283243b792ea7ac095a203e5aea3c221f78f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 17 Dec 2015 16:27:32 +0100
> Subject: [PATCH 1/2] gnu: Add r-rcpparmadillo.
>
> * gnu/packages/statistics.scm (r-rcpparmadillo): New variable.

[...]

> +    (properties `((upstream-name . "RcppArmadillo")))
> +    (build-system r-build-system)
> +    (propagated-inputs
> +     `(("r-rcpp" ,r-rcpp)))
> +    (home-page "https://github.com/RcppCore/RcppArmadillo")
> +    (synopsis "Rcpp integration for the linear algebra library 'Armadillo'")

“for the Armadillo linear algebra library” maybe?

> +    (description
> +     "Armadillo is a templated C++ linear algebra library that aims towards a
> +good balance between speed and ease of use.  Integer, floating point and
> +complex numbers are supported, as well as a subset of trigonometric and
> +statistics functions.  Various matrix decompositions are provided through
> +optional integration with LAPACK and ATLAS libraries.  This package includes
> +the header files from the templated Armadillo library.")
> +    ;; Armadillo is licensed under the MPL 2.0, while RcppArmadillo (the Rcpp
> +    ;; bindings to Armadillo) is licensed under the GNU GPL version 2 or
> +    ;; later, as is the rest of 'Rcpp'.
> +    (license license:gpl2+)))

Does this package bundle a copy of Armadillo?  If yes, it would be great
if we could make a separate Armadillo package that r-rcpparmadillo would
depend on.

WDYT?

> From 64e16086990806f2f30e651dbbf2ff62470b2fcc Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 17 Dec 2015 16:28:25 +0100
> Subject: [PATCH 2/2] gnu: Add AdaptiveSparsity.
>
> * gnu/packages/machine-learning.scm (r-adaptivesparsity): New variable.

LGTM.

Thanks!

Ludo’.