bug#23200: XFCE: selecting a style has no effect

bug#23200: XFCE: selecting a style has no effect

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi,

I've noticed surprising behavior on a fresh install of GuixSD v0.10.0
when using XFCE.  In XFCE, in the "Appearance" section of the settings,
under the "Style" tab, if you select an alternate style (e.g.,
"Xfce-kolors"), the color scheme does not actually get updated.  I
expected the colors of the windows to change, but they did not.

Is this expected?  Perhaps I'm missing something that needs to be done
to apply the change, but it seems like it just isn't working.

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#23200: XFCE: selecting a style has no effect

[Jookia]

On Sat, Apr 02, 2016 at 02:46:17PM -0700, Chris Marusich wrote:
> Hi,
> 
> I've noticed surprising behavior on a fresh install of GuixSD v0.10.0
> when using XFCE.  In XFCE, in the "Appearance" section of the settings,
> under the "Style" tab, if you select an alternate style (e.g.,
> "Xfce-kolors"), the color scheme does not actually get updated.  I
> expected the colors of the windows to change, but they did not.
> 
> Is this expected?  Perhaps I'm missing something that needs to be done
> to apply the change, but it seems like it just isn't working.

Currently GTK themes installed outside ~/.themes aren't found. There's a few
patches on the mailing list waiting review from a month or so ago.

> -- 
> Chris

Jookia.

bug#23200: XFCE: selecting a style has no effect

[Ricardo Wurmus]

Chris Marusich <cmmarusich@gmail.com> writes:

> I've noticed surprising behavior on a fresh install of GuixSD v0.10.0
> when using XFCE.  In XFCE, in the "Appearance" section of the settings,
> under the "Style" tab, if you select an alternate style (e.g.,
> "Xfce-kolors"), the color scheme does not actually get updated.  I
> expected the colors of the windows to change, but they did not.
>
> Is this expected?  Perhaps I'm missing something that needs to be done
> to apply the change, but it seems like it just isn't working.

Here’s what worked for me:

* install gnome-themes-standard into the system profile
* set GTK_DATA_PREFIX to “/run/current-system/profile”

The problem here is that GTK_DATA_PREFIX is not a list of directories in
which GTK+ should look for themes; it is just a single directory.  We
need to patch GTK+ to search through a list of directories instead.

~~ Ricardo

bug#23200: XFCE: selecting a style has no effect

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Ricardo Wurmus <rekado@elephly.net> writes:

> Here’s what worked for me:
>
> * install gnome-themes-standard into the system profile
> * set GTK_DATA_PREFIX to “/run/current-system/profile”

Can it be arranged for these two things to be done automatically in the
installation image?  I think it would be simple to add
"gnome-themes-standard" to the sample desktop.scm file we provide, but
I'm not sure how we would ensure that GTK_DATA_PREFIX gets set up
correctly.  Is there a mechanism in GuixSD for adding such environment
variables to /etc/profile, for example?

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#23200: XFCE: selecting a style has no effect

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Chris Marusich <cmmarusich@gmail.com> skribis:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Here’s what worked for me:
>>
>> * install gnome-themes-standard into the system profile
>> * set GTK_DATA_PREFIX to “/run/current-system/profile”
>
> Can it be arranged for these two things to be done automatically in the
> installation image?  I think it would be simple to add
> "gnome-themes-standard" to the sample desktop.scm file we provide, but
> I'm not sure how we would ensure that GTK_DATA_PREFIX gets set up
> correctly.  Is there a mechanism in GuixSD for adding such environment
> variables to /etc/profile, for example?

Definitely.

I’ve tested that with this patch changing colors under the “Style” tab
in Xfce does have an effect.

I’ll commit it shortly if there are no objections.

Thanks!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 573 bytes --]

diff --git a/gnu/system.scm b/gnu/system.scm
index 8e05254..a8744ea 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -421,6 +421,9 @@ export INFOPATH=$HOME/.guix-profile/share/info:/run/current-system/profile/share
 export XDG_DATA_DIRS=$HOME/.guix-profile/share:/run/current-system/profile/share
 export XDG_CONFIG_DIRS=$HOME/.guix-profile/etc/xdg:/run/current-system/profile/etc/xdg
 
+# 'GTK_DATA_PREFIX' must name one directory where themes are searched for.
+export GTK_DATA_PREFIX=/run/current-system/profile
+
 # Ignore the default value of 'PATH'.
 unset PATH
 

bug#23200: XFCE: selecting a style has no effect

[Ludovic Courtès]

ludo@gnu.org (Ludovic Courtès) skribis:

> I’ve tested that with this patch changing colors under the “Style” tab
> in Xfce does have an effect.
>
> I’ll commit it shortly if there are no objections.

Pushed a slightly different version as
ae05e366bea4517f1e428799f00f11997ccef661.

Thanks!

Ludo’.

bug#23200: XFCE: selecting a style has no effect

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> ludo@gnu.org (Ludovic Courtès) skribis:
>
>> I’ve tested that with this patch changing colors under the “Style” tab
>> in Xfce does have an effect.
>>
>> I’ll commit it shortly if there are no objections.
>
> Pushed a slightly different version as
> ae05e366bea4517f1e428799f00f11997ccef661.

This fixed the issue for me.  Thanks!

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#23200: XFCE: selecting a style has no effect

[Jookia]

On Mon, Apr 04, 2016 at 09:19:47PM -0700, Chris Marusich wrote:
> ludo@gnu.org (Ludovic Courtès) writes:
> 
> > ludo@gnu.org (Ludovic Courtès) skribis:
> >
> >> I’ve tested that with this patch changing colors under the “Style” tab
> >> in Xfce does have an effect.
> >>
> >> I’ll commit it shortly if there are no objections.
> >
> > Pushed a slightly different version as
> > ae05e366bea4517f1e428799f00f11997ccef661.
> 
> This fixed the issue for me.  Thanks!
> 
> -- 
> Chris

I heavily disagree with this approach for two reasons:

1) It doesn't work with user theme installs.
2) I have a patch that fixes this problem completely.
3) The fix I provided has been duplicated upstream in GTK+.

I suggest reverting this and applying my patch and read the full breakdown of
the issue and solution here:

https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00492.html

This was the patch I suggested earlier but seem to be ignored or missed.

Jookia.

bug#23200: XFCE: selecting a style has no effect

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Jookia <166291@gmail.com> writes:

> On Mon, Apr 04, 2016 at 09:19:47PM -0700, Chris Marusich wrote:
>> ludo@gnu.org (Ludovic Courtès) writes:
>> 
>> > ludo@gnu.org (Ludovic Courtès) skribis:
>> >
>> >> I’ve tested that with this patch changing colors under the “Style” tab
>> >> in Xfce does have an effect.
>> >>
>> >> I’ll commit it shortly if there are no objections.
>> >
>> > Pushed a slightly different version as
>> > ae05e366bea4517f1e428799f00f11997ccef661.
>> 
>> This fixed the issue for me.  Thanks!
>> 
>> -- 
>> Chris
>
> I heavily disagree with this approach for two reasons:
>
> 1) It doesn't work with user theme installs.
> 2) I have a patch that fixes this problem completely.
> 3) The fix I provided has been duplicated upstream in GTK+.
>
> I suggest reverting this and applying my patch and read the full breakdown of
> the issue and solution here:
>
> https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00492.html
>
> This was the patch I suggested earlier but seem to be ignored or missed.

Oh!  Thank you for the link.  Ludo, what do you think about Jookia's
comments?

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#23200: XFCE: selecting a style has no effect

[Ludovic Courtès]

Jookia <166291@gmail.com> skribis:

> On Mon, Apr 04, 2016 at 09:19:47PM -0700, Chris Marusich wrote:
>> ludo@gnu.org (Ludovic Courtès) writes:
>> 
>> > ludo@gnu.org (Ludovic Courtès) skribis:
>> >
>> >> I’ve tested that with this patch changing colors under the “Style” tab
>> >> in Xfce does have an effect.
>> >>
>> >> I’ll commit it shortly if there are no objections.
>> >
>> > Pushed a slightly different version as
>> > ae05e366bea4517f1e428799f00f11997ccef661.
>> 
>> This fixed the issue for me.  Thanks!
>> 
>> -- 
>> Chris
>
> I heavily disagree with this approach for two reasons:
>
> 1) It doesn't work with user theme installs.

Right, it’s mostly a hack to fix the immediate issue, which probably
covers many use cases since ‘xfce-desktop-service’ and
‘gnome-desktop-service’ install things globally.

> 2) I have a patch that fixes this problem completely.
> 3) The fix I provided has been duplicated upstream in GTK+.
>
> I suggest reverting this and applying my patch and read the full breakdown of
> the issue and solution here:
>
> https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00492.html

Oh, I had overlooked this one, sorry about that!

Ricardo raised some concerns in that thread, namely that the patch
hard-codes a specific profile name as well.  Did you have a chance to
look into it?

Thanks for the heads-up, and my apologies for overlooking it!

Ludo’.

bug#23200: XFCE: selecting a style has no effect

[Jookia]

On Tue, Apr 05, 2016 at 10:11:01AM +0200, Ludovic Courtès wrote:
> Ricardo raised some concerns in that thread, namely that the patch
> hard-codes a specific profile name as well.  Did you have a chance to
> look into it?

The patch I linked has no hardcoding (it's PATCHv2), it uses XDG_DATA_DIRS.

> Thanks for the heads-up, and my apologies for overlooking it!

No problem.

> Ludo’.

Jookia.