From mboxrd@z Thu Jan 1 00:00:00 1970 From: John J Foerch Subject: Re: [PATCH] gnu: Add di. Date: Mon, 04 Jul 2016 21:53:07 -0400 Message-ID: <87d1ms97gc.fsf@hecubus.retroj.net> References: <87poqvam4v.fsf@hecubus.retroj.net> <20160703210212.GA22355@jasmine> <87eg7a9y7e.fsf@hecubus.retroj.net> <87y45i83pi.fsf@hecubus.retroj.net> <87eg79kims.fsf@gmail.com> <87k2h18m91.fsf@hecubus.retroj.net> <20160704190733.GC8480@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKFYH-0008AO-FL for guix-devel@gnu.org; Mon, 04 Jul 2016 21:53:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKFYB-0003k4-CJ for guix-devel@gnu.org; Mon, 04 Jul 2016 21:53:28 -0400 Received: from plane.gmane.org ([80.91.229.3]:34737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKFYB-0003jx-5D for guix-devel@gnu.org; Mon, 04 Jul 2016 21:53:23 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bKFY2-0007J4-0k for guix-devel@gnu.org; Tue, 05 Jul 2016 03:53:14 +0200 Received: from 152.160.144.141 ([152.160.144.141]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 05 Jul 2016 03:53:14 +0200 Received: from jjfoerch by 152.160.144.141 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 05 Jul 2016 03:53:14 +0200 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Leo Famulari writes: > On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote: >> * gnu/packages/admin.scm (di): New variable. > > A few final nitpicks before others make a decision about the test suite > ;) > >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (delete 'configure) >> + (delete 'check) > > We prefer to use #:tests? #f instead of deleting the check phase. > >> + (add-before 'build 'setup-environment >> + (lambda* (#:key outputs #:allow-other-keys) >> + (setenv "CC" "gcc") >> + (setenv "prefix" (assoc-ref outputs "out")) >> + #t))) >> + #:make-flags (list "-e"))) > > I would like for '-e' to be expanded to '--environment-overrides'. It > seems that Schemers abhor abbreviations. > > Sorry for not mentioning these before. I can do them myself when pushing > if there are no other changes to be made. Sounds good. Thanks. -- John Foerch