From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/4] gnu: libtirpc: Remove the --disable-gssapi configure flag. Date: Mon, 29 Aug 2016 18:52:41 +0200 Message-ID: <87d1krwm92.fsf@gnu.org> References: <1472321979-10150-1-git-send-email-john@darrington.wattle.id.au> <1472321979-10150-4-git-send-email-john@darrington.wattle.id.au> <20160828094300.GK26988@macbook42.flashner.co.il> <20160828094535.GB25813@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bePnm-0002Gy-5w for guix-devel@gnu.org; Mon, 29 Aug 2016 12:52:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bePni-0004at-1H for guix-devel@gnu.org; Mon, 29 Aug 2016 12:52:49 -0400 In-Reply-To: <20160828094535.GB25813@jocasta.intra> (John Darrington's message of "Sun, 28 Aug 2016 11:45:35 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org, John Darrington John Darrington skribis: > On Sun, Aug 28, 2016 at 12:43:00PM +0300, Efraim Flashner wrote: > On Sat, Aug 27, 2016 at 08:19:39PM +0200, John Darrington wrote: > > From: John Darrington > >=20 > > * gnu/packages/onc-rpc.scm (libtirpc)[arguments]: Remove the --dis= able-gssapi > > configure flag. > > [inputs]: Add mit-krb5 > > --- > > gnu/packages/onc-rpc.scm | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > >=20 > > diff --git a/gnu/packages/onc-rpc.scm b/gnu/packages/onc-rpc.scm > > index d9b2f9d..d5858e8 100644 > > --- a/gnu/packages/onc-rpc.scm > > +++ b/gnu/packages/onc-rpc.scm > > @@ -20,6 +20,7 @@ > > #:use-module (guix licenses) > > #:use-module (guix packages) > > #:use-module (guix download) > > + #:use-module (gnu packages mit-krb5) > > #:use-module (guix build-system gnu)) > >=20=20 > > (define-public libtirpc > > @@ -36,16 +37,14 @@ > > "18a337wa4amf0k21wnimp3yzs5l3cxqndz4x3x8bm993zhfy= 5hs5")))) > > (build-system gnu-build-system) > > (arguments > > - '(;; Doesn't work with GNU GSS. > > - #:configure-flags '("--disable-gssapi") > > - > > - #:phases (alist-cons-after > > + '(#:phases (alist-cons-after > > 'unpack 'remote-dangling-symlink > > (lambda _ > > ;; Remote the dangling symlinks since it break= s the > > ;; 'patch-source-shebangs' file tree traversal. > > (delete-file "INSTALL")) > > %standard-phases))) > > + (inputs `(("mit-krb5" ,mit-krb5))) > > (home-page "http://sourceforge.net/projects/libtirpc/") > > (synopsis "Transport-independent Sun/ONC RPC implementation") > > (description > > --=20 > > 2.1.4 > >=20 >=20=20=20=20=20=20 > Has the issue with GNU GSS been fixed? Also, this would be a good ti= me > to switch to modify-phases while you're already touching the package. > > I'm not aware of any issue with GNU GSS which needs to be fixed. It is n= ot > an input to this package. I don't think there is any connection. It=E2=80=99s preferable to use GNU GSS rather than mit-krb5 if that=E2=80= =99s possible, which maybe it isn=E2=80=99t. > I'll have a look to see if modify-phases makes things simpler. Regardless, the patch LGTM. Thanks, Ludo=E2=80=99.