From: ng0 <ng0@we.make.ritual.n0.is>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 07/43] gnu: Add ghc-haskeline.
Date: Thu, 08 Sep 2016 23:23:40 +0000 [thread overview]
Message-ID: <87d1keq8lf.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87bn003c42.fsf@we.make.ritual.n0.is>
ng0 <ng0@we.make.ritual.n0.is> writes:
> Eric Bavier <ericbavier@openmailbox.org> writes:
>
>> On Sun, 4 Sep 2016 16:17:06 +0000
>> ng0 <ng0@we.make.ritual.n0.is> wrote:
>>
>>> * gnu/packages/haskell.scm (ghc-haskeline): New variable.
>>> ---
>>> gnu/packages/haskell.scm | 25 +++++++++++++++++++++++++
>>> 1 file changed, 25 insertions(+)
>>>
>>> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
>>> index f3d43c4..8c6aee0 100644
>>> --- a/gnu/packages/haskell.scm
>>> +++ b/gnu/packages/haskell.scm
>>> @@ -6558,4 +6558,29 @@ via bindings to the curses library. Terminfo allows POSIX systems
>>> to interact with a variety of terminals using a standard set of capabilities.")
>>> (license license:bsd-3)))
>>>
>>> +(define-public ghc-haskeline
>>> + (package
>>> + (name "ghc-haskeline")
>>> + (version "0.7.2.3")
>>> + (source
>>> + (origin
>>> + (method url-fetch)
>>> + (uri (string-append
>>> + "https://hackage.haskell.org/package/haskeline/haskeline-"
>>> + version ".tar.gz"))
>>> + (sha256
>>> + (base32
>>> + "09wd6sxgn65xxpk7dhy1cg3ywlbk0ccqq7xylycwk4zazy3gjgkd"))))
>>> + (build-system haskell-build-system)
>>> + (inputs
>>> + `(("ghc-terminfo" ,ghc-terminfo)))
>>> + (home-page "https://github.com/judah/haskeline")
>>> + (synopsis "A command-line interface for user input, written in Haskell.")
>> ^
>> Could you run these packages through 'guix lint'? It should warn about
>> the "A" at the beginning of a synopsis.
>
> Okay, thanks for spotting it.
>
>>> + (description
>>> + "Haskeline provides a user interface for line input in command-line
>>> +programs. This library is similar in purpose to readline, but since it
>>> +is written in Haskell it is (hopefully) more easily used in other Haskell
>>> +programs.")
>>> + (license license:bsd-3)))
>>> +
>>> ;;; haskell.scm ends here
>>
>> While adding ghc packages in the past, I've tried to keep the packages
>> alphabetically sorted. I'm not sure whether there's concensus on doing
>> that. We have 'guix edit', but for catch-all modules like (gnu
>> packages haskell) I think it's still nice to have some semblance of
>> order. We added a plea message at the top of gnu/packages/python.scm;
>> maybe we should add one to gnu/packages/haskell.scm. What do others
>> think?
>>
>> `~Eric
>
> I find it time consuming to search for the place in a file the length of
> perl.scm, haskell.scm, python.scm to fit in my packages.
>
> I think for haskell this was not 100% sorted, for perl there's almost
> A-Z sorting.
>
> It's nice to have, but the more these files grow, the more time you
> spend with correcting the commits where the A-Z plea message was
> ignored or overlooked.
> If all of them were sorted and it would be pointed out in
> "Documentation > Contributing" I'd agree, but at the moment I won't fix
> this patch series.
>
> Usually for these long files I just do an "M-g g 80000" to jump to the
> very end.
Just to add to this: I'm okay with this, I do it for perl and python
when I can, but this patchseries is just too long to shuffle it all
around for no actual improvement in code.
As the modules grow in lines of code, we should add this to
documentation that at least a first letter should be sorted
alphabetically, though it should not be an absolute requirement for
various reasons.
In my opinion if you search for a package name you will find out the
line and file where it starts, which is enough.
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
next prev parent reply other threads:[~2016-09-08 23:24 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 16:17 [PATCH 01/43] gnu: Add ghc-base16-bytestring ng0
2016-09-04 16:17 ` [PATCH 02/43] gnu: Add ghc-binary ng0
2016-09-04 16:17 ` [PATCH 03/43] gnu: ghc-cryptonite: Update to 0.19 ng0
2016-09-04 16:17 ` [PATCH 04/43] gnu: Add ghc-cryptohash ng0
2016-09-04 16:17 ` [PATCH 05/43] gnu: Add ghc-data-ordlist ng0
2016-09-04 16:17 ` [PATCH 06/43] gnu: Add ghc-terminfo ng0
2016-09-04 16:17 ` [PATCH 07/43] gnu: Add ghc-haskeline ng0
2016-09-06 3:27 ` Eric Bavier
2016-09-06 22:19 ` ng0
2016-09-08 23:23 ` ng0 [this message]
2016-09-04 16:17 ` [PATCH 08/43] gnu: Add ghc-regex-applicative ng0
2016-09-04 16:17 ` [PATCH 09/43] gnu: Add ghc-regex-tdfa ng0
2016-09-04 16:17 ` [PATCH 10/43] gnu: Add ghc-regex-compat-tdfa ng0
2016-09-04 16:17 ` [PATCH 11/43] gnu: Add ghc-tasty-th ng0
2016-09-04 16:17 ` [PATCH 12/43] gnu: Add ghc-sandi ng0
2016-09-04 16:17 ` [PATCH 13/43] gnu: Add ghc-bytestring-handle ng0
2016-09-04 16:17 ` [PATCH 14/43] gnu: Add ghc-tar ng0
2016-09-04 16:17 ` [PATCH 15/43] gnu: Add ghc-transformers ng0
2016-09-05 11:48 ` ng0
2016-09-04 16:17 ` [PATCH 16/43] gnu: Add ghc-findbin ng0
2016-09-04 16:17 ` [PATCH 17/43] gnu: Add ghc-patience ng0
2016-09-04 16:17 ` [PATCH 18/43] gnu: Add ghc-monads-tf ng0
2016-09-04 16:17 ` [PATCH 19/43] gnu: Add ghc-bytestring ng0
2016-09-05 20:37 ` Leo Famulari
2016-09-06 22:22 ` ng0
2016-09-07 2:35 ` Leo Famulari
2016-09-04 16:17 ` [PATCH 20/43] gnu: Add ghc-colour ng0
2016-09-04 16:17 ` [PATCH 21/43] gnu: Add ghc-directory ng0
2016-09-04 16:17 ` [PATCH 22/43] gnu: Add ghc-process ng0
2016-09-04 16:17 ` [PATCH 23/43] gnu: Add ghc-wl-pprint-text ng0
2016-09-04 16:17 ` [PATCH 24/43] gnu: ghc-fgl: Update to 5.5.3.0 ng0
2016-09-04 16:17 ` [PATCH 25/43] gnu: Add ghc-fgl-arbitrary ng0
2016-09-04 16:17 ` [PATCH 26/43] gnu: Add ghc-graphviz ng0
2016-09-04 16:17 ` [PATCH 27/43] gnu: Add ghc-array ng0
2016-09-04 16:17 ` [PATCH 28/43] gnu: Add ghc-findbin ng0
2016-09-04 16:17 ` [PATCH 29/43] gnu: Add ghc-constraints ng0
2016-09-04 16:17 ` [PATCH 30/43] gnu: Add ghc-lifted-async ng0
2016-09-04 16:17 ` [PATCH 31/43] gnu: Add ghc-system-filepath-bootstrap ng0
2016-09-04 16:17 ` [PATCH 32/43] gnu: Add ghc-system-fileio-bootstrap ng0
2016-09-04 16:17 ` [PATCH 33/43] gnu: Add ghc-shelly ng0
2016-09-04 16:17 ` [PATCH 34/43] gnu: Add ghc-options-bootstrap ng0
2016-09-04 16:17 ` [PATCH 35/43] gnu: Add ghc-chell ng0
2016-09-04 16:17 ` [PATCH 36/43] gnu: Add ghc-chell-quickcheck-bootstrap ng0
2016-09-05 20:36 ` Leo Famulari
2016-09-06 22:24 ` ng0
2016-09-07 2:36 ` Leo Famulari
2016-09-04 16:17 ` [PATCH 37/43] gnu: Add ghc-chell-quickcheck ng0
2016-09-04 16:17 ` [PATCH 38/43] gnu: Add ghc-options ng0
2016-09-04 16:17 ` [PATCH 39/43] gnu: Add ghc-system-filepath ng0
2016-09-04 16:17 ` [PATCH 40/43] gnu: Add ghc-system-fileio ng0
2016-09-04 16:17 ` [PATCH 41/43] gnu: Add ghc-transformers@0.4.2.0 ng0
2016-09-04 16:17 ` [PATCH 42/43] gnu: Add ghc-directory@1.2.2.0 ng0
2016-09-04 16:17 ` [PATCH 43/43] gnu: Add darcs ng0
2016-09-04 16:37 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1keq8lf.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.