From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 7/7] gnu: Add r-bioccheck.
Date: Mon, 19 Sep 2016 14:37:55 +0200
Message-ID: <87d1k0m5ek.fsf@elephly.net>
References: <87bmzps87x.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1blxpy-0000QJ-SL
	for guix-devel@gnu.org; Mon, 19 Sep 2016 08:38:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1blxpv-00056y-6J
	for guix-devel@gnu.org; Mon, 19 Sep 2016 08:38:18 -0400
In-reply-to: <87bmzps87x.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

> * gnu/packages/bioinformatics.scm (r-bioccheck): New variable.
> ---
>  gnu/packages/bioinformatics.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index 902d1d2..00a4161 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -5426,6 +5426,35 @@ like automatically generated help option and usage, support for default
>  values, positional argument support, etc.")                                                                     
>      (license license:gpl2+)))
>  
> +(define-public r-bioccheck
> +  (package
> +    (name "r-bioccheck")
> +    (version "1.8.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (bioconductor-uri "BiocCheck" version))
> +              (sha256
> +               (base32
> +                "0bvkhxmr25nb0gkncifbc3x48i5zgls3737g3xais6jx16wd4q35"))))
> +    (properties
> +     `((upstream-name . "BiocCheck")))
> +    (build-system r-build-system)
> +    (inputs
> +     `(("which" ,which)))

Is this a native input?

> +    (propagated-inputs
> +     `(("r-graph" ,r-graph)
> +       ("r-knitr" ,r-knitr)
> +       ("r-httr" ,r-httr)
> +       ("r-optparse" ,r-optparse)
> +       ("r-devtools" ,r-devtools)
> +       ("r-biocinstaller" ,r-biocinstaller)
> +       ("r-biocviews" ,r-biocviews)))
> +    (home-page "http://bioconductor.org/packages/BiocCheck")
> +    (synopsis "Executes Bioconductor-specific package checks")
> +    (description "This package executes Bioconductor-specific
> +package checks.")

Well… okay. :)  It would be nice if it was a little more specific.

Maybe:

   This package contains tools to perform quality checks on R packages
   that are to be submitted to the Bioconductor repository.

WDYT?

~~ Ricardo