From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: 07/07: guix: python-build-system: Fix an outdated comment. Date: Sun, 16 Oct 2016 00:16:27 +0200 Message-ID: <87d1j1b6mc.fsf@gnu.org> References: <20161013152324.1276.70078@vcs.savannah.gnu.org> <20161013152324.EF9C7220170@vcs.savannah.gnu.org> <87eg3kyrie.fsf@netris.org> <20161013193905.GA8814@jasmine> <20161013224529.1a55e84a@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvXFp-0000tE-PK for guix-devel@gnu.org; Sat, 15 Oct 2016 18:16:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvXFm-0003nX-JJ for guix-devel@gnu.org; Sat, 15 Oct 2016 18:16:33 -0400 In-Reply-To: <20161013224529.1a55e84a@scratchpost.org> (Danny Milosavljevic's message of "Thu, 13 Oct 2016 22:45:29 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org Danny Milosavljevic skribis: >> Sorry, I didn't realize that altering comments here would have an >> effect; I would have warned Hartmut if I had. > > Out of curiousity, why does it have an effect? The file is imported in the build environment (chroot) of all the packages that use =E2=80=98python-build-system=E2=80=99. It=E2=80=99s an i= nput of the derivation of those packages, so when it changes, all these derivations change. Hartmut Goebel skribis: >> Sorry, I didn't realize that altering comments here would have an >> effect; I would have warned Hartmut if I had. > > I'm sorry, too. I didn't expect that changing a comment would have any > impact on building packages. Aren't the the files converted to some > canonical form prior to deciding whether they changed? No. There=E2=80=99s no =E2=80=9Cdecision=E2=80=9D as to whether they chang= ed; instead, they just happen to be part of the hash of the output file name. That said, don=E2=80=99t be sorry gentlefolks: these things happen. ;-) Ludo=E2=80=99.