From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH 05/16] gnu: Add python-testpath.
Date: Tue, 01 Nov 2016 14:36:03 +0100
Message-ID: <87d1ifmif0.fsf@gnu.org>
References: <20161101122046.751-1-ricardo.wurmus@mdc-berlin.de>
	<20161101122046.751-6-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1ZDC-0003tE-VJ
	for guix-devel@gnu.org; Tue, 01 Nov 2016 09:34:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1ZD9-0000D7-2R
	for guix-devel@gnu.org; Tue, 01 Nov 2016 09:34:46 -0400
In-reply-to: <20161101122046.751-6-ricardo.wurmus@mdc-berlin.de>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org


Ricardo Wurmus writes:

> * gnu/packages/python.scm (python-testpath, python2-testpath): New
> variables.
> ---
>  gnu/packages/python.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9785b5e..e6f537e 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4583,6 +4583,48 @@ installing kernelspecs for use with Jupyter frontends.")
>  (define-public python2-ipykernel
>    (package-with-python2 python-ipykernel))
>  
> +

I don't think two blank lines are needed here.

> +(define-public python-testpath
> +  (package
> +    (name "python-testpath")
> +    (version "0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/jupyter/testpath/archive/"
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "04kh3fgvmqz6cfcw79q70qwjz7ib7lxm27cc548iy2rpr33qqf55"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f ; this package does not even have a setup.py
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'install)
> +         (replace 'build
> +                  (lambda* (#:key inputs outputs #:allow-other-keys)
> +                    (let ((dir (string-append
> +                                (assoc-ref outputs "out")
> +                                "/lib/python"
> +                                (string-take (string-take-right
> +                                              (assoc-ref inputs "python") 5) 3)
> +                                "/site-packages/testpath")))
> +                      (mkdir-p dir)
> +                      (copy-recursively "testpath" dir))
> +                    #t)))))
> +    (home-page "https://github.com/takluyver/testpath")
> +    (synopsis "Test utilities for code working with files and commands")
> +    (description
> +     "Testpath is a collection of utilities for Python code working with files
> +and commands.  It contains functions to check things on the filesystem, and
> +tools for mocking system commands and recording calls to those.")
> +    (license license:expat)))
> +
> +(define-public python2-testpath
> +  (package-with-python2 python-testpath))
> +
>  (define-public python-ipython
>    (package
>      (name "python-ipython")

Otherwise LGTM.

Kind regards,
Roel Janssen