From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 05/16] gnu: Add python-testpath.
Date: Tue, 01 Nov 2016 14:36:03 +0100 [thread overview]
Message-ID: <87d1ifmif0.fsf@gnu.org> (raw)
In-Reply-To: <20161101122046.751-6-ricardo.wurmus@mdc-berlin.de>
Ricardo Wurmus writes:
> * gnu/packages/python.scm (python-testpath, python2-testpath): New
> variables.
> ---
> gnu/packages/python.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9785b5e..e6f537e 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4583,6 +4583,48 @@ installing kernelspecs for use with Jupyter frontends.")
> (define-public python2-ipykernel
> (package-with-python2 python-ipykernel))
>
> +
I don't think two blank lines are needed here.
> +(define-public python-testpath
> + (package
> + (name "python-testpath")
> + (version "0.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/jupyter/testpath/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "04kh3fgvmqz6cfcw79q70qwjz7ib7lxm27cc548iy2rpr33qqf55"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f ; this package does not even have a setup.py
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'install)
> + (replace 'build
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let ((dir (string-append
> + (assoc-ref outputs "out")
> + "/lib/python"
> + (string-take (string-take-right
> + (assoc-ref inputs "python") 5) 3)
> + "/site-packages/testpath")))
> + (mkdir-p dir)
> + (copy-recursively "testpath" dir))
> + #t)))))
> + (home-page "https://github.com/takluyver/testpath")
> + (synopsis "Test utilities for code working with files and commands")
> + (description
> + "Testpath is a collection of utilities for Python code working with files
> +and commands. It contains functions to check things on the filesystem, and
> +tools for mocking system commands and recording calls to those.")
> + (license license:expat)))
> +
> +(define-public python2-testpath
> + (package-with-python2 python-testpath))
> +
> (define-public python-ipython
> (package
> (name "python-ipython")
Otherwise LGTM.
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2016-11-01 13:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 12:20 [PATCH 00/16] Add Jupyter Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 01/16] gnu: python-traitlets: Update to 4.2.0 Ricardo Wurmus
2016-11-01 13:19 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 02/16] gnu: Add python-jupyter-core Ricardo Wurmus
2016-11-01 13:22 ` Roel Janssen
2016-11-04 10:21 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 03/16] gnu: Add python-jupyter-client Ricardo Wurmus
2016-11-01 13:27 ` Roel Janssen
2016-11-04 10:22 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 04/16] gnu: Add python-ipykernel Ricardo Wurmus
2016-11-01 13:32 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 05/16] gnu: Add python-testpath Ricardo Wurmus
2016-11-01 13:36 ` Roel Janssen [this message]
2016-11-04 10:25 ` Ricardo Wurmus
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 10:25 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 06/16] gnu: Add python-html5lib-0.9 Ricardo Wurmus
2016-11-01 13:40 ` Roel Janssen
2016-11-01 14:31 ` Ricardo Wurmus
2016-11-01 18:24 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 07/16] gnu: Add python-nbformat Ricardo Wurmus
2016-11-01 14:27 ` Roel Janssen
2016-11-04 10:27 ` Ricardo Wurmus
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 10:28 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 08/16] gnu: Add python-bleach Ricardo Wurmus
2016-11-01 13:59 ` Roel Janssen
2016-11-04 10:32 ` Ricardo Wurmus
2016-11-04 13:01 ` Roel Janssen
2016-11-01 14:00 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 09/16] gnu: Add python-entrypoints Ricardo Wurmus
2016-11-01 16:18 ` Roel Janssen
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 16:54 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 10/16] gnu: Add python-nbconvert Ricardo Wurmus
2016-11-01 16:23 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 11/16] gnu: Add python-notebook Ricardo Wurmus
2016-11-01 18:10 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 12/16] gnu: Add python-widgetsnbextension Ricardo Wurmus
2016-11-01 18:11 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 13/16] gnu: Add python-ipywidgets Ricardo Wurmus
2016-11-01 18:12 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 14/16] gnu: Add python-jupyter-console Ricardo Wurmus
2016-11-01 18:15 ` Roel Janssen
2016-11-04 16:47 ` Ricardo Wurmus
2016-11-04 17:40 ` Roel Janssen
2016-11-04 17:49 ` Hartmut Goebel
2016-11-01 12:20 ` [PATCH 15/16] gnu: python-ipython: Update to 4.0.0 Ricardo Wurmus
2016-11-01 18:18 ` Roel Janssen
2016-11-04 17:10 ` Ricardo Wurmus
2016-11-04 17:43 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 16/16] gnu: Add jupyter Ricardo Wurmus
2016-11-01 18:20 ` Roel Janssen
2016-11-04 20:26 ` Ricardo Wurmus
2016-11-01 13:16 ` [PATCH 00/16] Add Jupyter Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ifmif0.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.