From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH v4 1/1] gnu: Add plantuml.
Date: Fri, 04 Nov 2016 15:46:57 +0100
Message-ID: <87d1ibfgke.fsf@gnu.org>
References: <87pomiakvk.fsf@elephly.net>
	<20161102110341.28576-1-theodoros.for@openmailbox.org>
	<8737jac7af.fsf@gnu.org> <8760o4zlfd.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60204)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c2fkR-0001p7-UK
	for guix-devel@gnu.org; Fri, 04 Nov 2016 10:45:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c2fkO-00081N-Sl
	for guix-devel@gnu.org; Fri, 04 Nov 2016 10:45:40 -0400
In-reply-to: <8760o4zlfd.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: Guix-devel <guix-devel@gnu.org>


Theodoros Foradis writes:

> Roel Janssen writes:
>
>> I tried running plantuml with the following snippet:
>> @startuml
>> A <..> B
>> @enduml
>>
>> And it crashes because it attempts to run "/usr/bin/dot".
>>
>> With the following snippet, we replace this "/usr/bin/dot" dependency
>> with the proper one from the graphviz input:
>>
>> (add-before 'build 'patch-usr-bin-dot
>>   (lambda* (#:key inputs #:allow-other-keys)
>>     (let ((dot (string-append (assoc-ref inputs "graphviz")
>>                                "/bin/dot")))
>>       (substitute*
>>         "src/net/sourceforge/plantuml/cucadiagram/dot/GraphvizLinux.java"
>>         (("/usr/bin/dot") dot)))))
>>
>
> Nice catch! Thanks for testing that.
>
>> Could you add this snippet?
>>
>> Other than this, it works fine for me.
>>
>> Kind regards,
>> Roel Janssen
>
> Let me know if I need to post an updated patch.

Please do.  Have all comments been incorporated into this version of the
patch?  If so, I guess we can push the version that includes my snippet,
unless anyone still has any comments.

Thanks!

Kind regards,
Roel Janssen