From: Ricardo Wurmus <rekado@elephly.net>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 09/16] gnu: Add python-entrypoints.
Date: Fri, 04 Nov 2016 17:54:00 +0100 [thread overview]
Message-ID: <87d1ib9oev.fsf@elephly.net> (raw)
In-Reply-To: <76ac69b7-fc3c-2701-9348-bb64a66f5cc5@crazy-compilers.com>
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Am 01.11.2016 um 13:20 schrieb Ricardo Wurmus:
>> + (modify-phases %standard-phases
>> + (delete 'build)
>> + (replace 'install
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (python-version ((@@ (guix build python-build-system)
>> + get-python-version)
>> + (assoc-ref inputs "python")))
>> + (target (string-append out "/lib/python" python-version
>> + "/site-packages/")))
>> + (mkdir-p target)
>> + (call-with-output-file (string-append target "entrypoints.egg-info")
>> + (lambda (port)
>> + (format port "\
>> +Metadata-Version: 1.1
>> +Name: entrypoints
>> +Version: ~a
>> +Summary: Discover and load entry points from installed packages
>> +Author: Thomas Kluyver
>> +Author-email: thomas@kluyver.me.uk
>> +Classifier: License :: OSI Approved :: MIT License
>> +" ,version)))
>> + (install-file "entrypoints.py" target)
>> + #t))))))
>
> Instread of this I recommend adding a minimal setup.py and let the
> build-system do the job. This would be more future proof.
That’s a good idea. I did this and it really simplified the patch a
lot. Thanks!
~~ Ricardo
next prev parent reply other threads:[~2016-11-04 16:54 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 12:20 [PATCH 00/16] Add Jupyter Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 01/16] gnu: python-traitlets: Update to 4.2.0 Ricardo Wurmus
2016-11-01 13:19 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 02/16] gnu: Add python-jupyter-core Ricardo Wurmus
2016-11-01 13:22 ` Roel Janssen
2016-11-04 10:21 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 03/16] gnu: Add python-jupyter-client Ricardo Wurmus
2016-11-01 13:27 ` Roel Janssen
2016-11-04 10:22 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 04/16] gnu: Add python-ipykernel Ricardo Wurmus
2016-11-01 13:32 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 05/16] gnu: Add python-testpath Ricardo Wurmus
2016-11-01 13:36 ` Roel Janssen
2016-11-04 10:25 ` Ricardo Wurmus
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 10:25 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 06/16] gnu: Add python-html5lib-0.9 Ricardo Wurmus
2016-11-01 13:40 ` Roel Janssen
2016-11-01 14:31 ` Ricardo Wurmus
2016-11-01 18:24 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 07/16] gnu: Add python-nbformat Ricardo Wurmus
2016-11-01 14:27 ` Roel Janssen
2016-11-04 10:27 ` Ricardo Wurmus
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 10:28 ` Ricardo Wurmus
2016-11-01 12:20 ` [PATCH 08/16] gnu: Add python-bleach Ricardo Wurmus
2016-11-01 13:59 ` Roel Janssen
2016-11-04 10:32 ` Ricardo Wurmus
2016-11-04 13:01 ` Roel Janssen
2016-11-01 14:00 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 09/16] gnu: Add python-entrypoints Ricardo Wurmus
2016-11-01 16:18 ` Roel Janssen
2016-11-02 8:23 ` Hartmut Goebel
2016-11-04 16:54 ` Ricardo Wurmus [this message]
2016-11-01 12:20 ` [PATCH 10/16] gnu: Add python-nbconvert Ricardo Wurmus
2016-11-01 16:23 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 11/16] gnu: Add python-notebook Ricardo Wurmus
2016-11-01 18:10 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 12/16] gnu: Add python-widgetsnbextension Ricardo Wurmus
2016-11-01 18:11 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 13/16] gnu: Add python-ipywidgets Ricardo Wurmus
2016-11-01 18:12 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 14/16] gnu: Add python-jupyter-console Ricardo Wurmus
2016-11-01 18:15 ` Roel Janssen
2016-11-04 16:47 ` Ricardo Wurmus
2016-11-04 17:40 ` Roel Janssen
2016-11-04 17:49 ` Hartmut Goebel
2016-11-01 12:20 ` [PATCH 15/16] gnu: python-ipython: Update to 4.0.0 Ricardo Wurmus
2016-11-01 18:18 ` Roel Janssen
2016-11-04 17:10 ` Ricardo Wurmus
2016-11-04 17:43 ` Roel Janssen
2016-11-01 12:20 ` [PATCH 16/16] gnu: Add jupyter Ricardo Wurmus
2016-11-01 18:20 ` Roel Janssen
2016-11-04 20:26 ` Ricardo Wurmus
2016-11-01 13:16 ` [PATCH 00/16] Add Jupyter Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ib9oev.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.