Re: [PATCH] gnu: Add Handbrake.

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@centurylink.net> skribis:

> On Mon, 31 Oct 2016 10:30:40 +0100
> Ricardo Wurmus <rekado@elephly.net> wrote:
>
>> Eric Bavier <bavier@member.fsf.org> writes:
>> 
>> > * gnu/packages/video.scm (handbrake): New variable.
>> > * gnu/packages/patches/handbrake-pkg-config-path.patch: New patch.
>> > * gnu/local.mk (dist_patch_DATA): Add it.  
>> 
>> Yay, thanks for the patch!
>
> Thanks for the feedback!  I've incorporated your and Efraim's
> suggestions in the attached patch.  
>
> The resulting Handbrake mostly works, but the default transcoding
> presets and gui icons are missing.  I've done as much as I can to debug
> this, but I can't put any more time into it.  I could commit this
> as-is and fix it later, or someone else could pick it up.

There are other packages with missing icons, I think this can be fixed
separately.

So I’d say you can commit it.

Thank you,
Ludo’.