From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add php Date: Mon, 21 Nov 2016 09:46:51 +0100 Message-ID: <87d1hp1apw.fsf@gnu.org> References: <20161030130828.3797d37d@polymos.lepiller.eu> <20161030175105.1f6eeff2@polymos.lepiller.eu> <87ins9s9y1.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> <20161102224052.7ec98d2d@lepiller.eu> <87eg2k8xp2.fsf@gnu.org> <20161111173123.51375f43@polymos.lepiller.eu> <87eg2etms7.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87bmxitmdi.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87y40m8ben.fsf@gnu.org> <8760nqtbg6.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87lgwm6rwx.fsf@gnu.org> <87h977c6ux.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <89e7b7e761086ed5ace17abc9a7bf435@lepiller.eu> <87a8cyc6fb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20161117203428.3344dc06@lepiller.eu> <8760nldeh0.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20161118182504.201e90f5@lepiller.eu> <87polsbqx9.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87twb2f5j0.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8kFd-00050x-GU for guix-devel@gnu.org; Mon, 21 Nov 2016 03:47:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8kFa-0006wR-EF for guix-devel@gnu.org; Mon, 21 Nov 2016 03:46:57 -0500 In-Reply-To: <87twb2f5j0.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Sun, 20 Nov 2016 18:02:59 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke skribis: > Marius Bakke writes: > >>>> > Failures in tests caused by external gd are not too serious to >>>> > require us to switch to the bundled one I think. We may not even >>>> > need to patch our libgd with php specific patches, since the >>>> > failures are only slight deviation from the spec on corner cases. >>>> > If you prefer that we apply these patches too, then we could, and I >>>> > would still try to keep that up to date. >>>>=20 >>>> OK. Let's use external gd for now barring any serious issues. >>>>=20 >>>> > >>>> > What I am more worried about are the iconv crashes. That may be due >>>> > to lacking locales though. >>>>=20 >>>> You could try commenting them out and adding "glibc-locales" to >>>> native-inputs. Not sure if they will get picked up by that however. >>>>=20 >>>> A better test may be to try out that particular functionality using >>>> the installed version of php. If that works, we can be reasonably >>>> sure that dropping the tests is fine. >>>>=20 >>>> Attached is the final product, after adding a "gd-for-php" variable >>>> with the two upstream patches, as well as sqlite-3.15.1 (separate >>>> patch). >>>>=20 >>>> I'll push this tomorrow if there are no further comments. Thanks for >>>> your perseverance :) >>> Just one question: why defining gd-for-php with define, and not >>> define-public? >> >> It's to prevent it from showing up when people are searching for 'gd', >> and also to prevent it from being included by other files. >> >> It's only a temporary measure until the next version is released, so I >> saw no reason to export it. >> >> I'm on my way out, but will commit this tomorrow most likely :-) > > Sorry for the delay, PHP is in master now! Cool, thank you all! Ludo=E2=80=99.