From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 1/2] gnu: psyclpc: Make it reproducible. Date: Sat, 26 Nov 2016 10:02:10 +0100 Message-ID: <87d1hihawd.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161123190437.23966-1-ng0@libertad.pw> <20161123190437.23966-2-ng0@libertad.pw> <20161126060614.GB12092@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAYsB-0003Fz-JM for guix-devel@gnu.org; Sat, 26 Nov 2016 04:02:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAYs8-00053H-HF for guix-devel@gnu.org; Sat, 26 Nov 2016 04:02:15 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57268) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAYs8-000530-Dp for guix-devel@gnu.org; Sat, 26 Nov 2016 04:02:12 -0500 In-Reply-To: <20161126060614.GB12092@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , ng0 Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Wed, Nov 23, 2016 at 07:04:36PM +0000, ng0 wrote: >> * gnu/packages/psyc.scm (psyclpc): Make it reproducible. >> --- >> gnu/packages/psyc.scm | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >>=20 >> diff --git a/gnu/packages/psyc.scm b/gnu/packages/psyc.scm >> index 03df188..01bbae6 100644 >> --- a/gnu/packages/psyc.scm >> +++ b/gnu/packages/psyc.scm >> @@ -1,5 +1,5 @@ >> ;;; GNU Guix --- Functional package management for GNU >> -;;; Copyright =C2=A9 2016 ng0 >> +;;; Copyright =C2=A9 2016 ng0 >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -155,7 +155,7 @@ including psyced.") >>=20=20 >> ;; This commit removes the historic bundled pcre, not released as a tar= ball so far. >> (define-public psyclpc >> - (let* ((commit "8bd51f2a4847860ba8b82dc79348ab37d516011e") >> + (let* ((commit "61cf9aa81297085e5c40170fd01221c752f8deba") >> (revision "1")) > > Is it a newer commit? I think the revision counter should increase to 2. > Or else `guix pcakage -u` won't update users' psyclpc installations. Doesn't it? I was under the impression that `guix package -u` detected when the derivation has changed, and updates to the current version regardless of version number. I do agree that incrementing the revision is good regardless, since users will know that the code has changed, and not just some dependency. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlg5T5IACgkQoqBt8qM6 VPrMCQf9EZm6uXctNKajjJfqXJzaRQ3GH7aF2oDoQ8xjUrY6k2itFlO/UMCgXDdt Jt+2Zl00MLNIq7T5EpJq6f1sZk+HmtI/TsEhAm1zYwz1sWMpD9tk4SIJTxoLvFHg XyTIIVqkXWkLWlrtvLlY54IyzKzmrbBwFOGfVq3FCK9ZpzlRg6XIhCZAalqP++QB gjxdUJDl7s2DN+z/cgBusbwyPMB/0tB0DdZyoyfLppUOO2fRX+EzRXMbOXpZMX/R UT+1bam0roT4UR8XjSI8hwRaZjBkAsDM5UsPz0fYf0MP7ZpaE9qixK3wYXo5V4OK JBJnDb3NNKMMQ6zUF1iAX2TbdaI3hw== =Y87w -----END PGP SIGNATURE----- --=-=-=--