From: taylanbayirli@gmail.com ("Taylan Ulrich Bayırlı/Kammer")
To: guix-devel@gnu.org
Subject: [PATCH] gnu: leptonica: Update to 1.73.
Date: Fri, 23 Dec 2016 22:10:09 +0100 [thread overview]
Message-ID: <87d1giwdvy.fsf@gmail.com> (raw)
I struggled for days with the following bug and ultimately decided to
disable tests for 1.73 to sidestep it entirely; tests should be
re-enabled with the next release.
https://github.com/DanBloomberg/leptonica/issues/224
===File
/home/taylan/src/guix/0001-gnu-leptonica-Update-to-1.73.patch===
From 38ca93d5a6b78b9a3d3fafbec36cf3da7b0c371b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
<taylanbayirli@gmail.com>
Date: Thu, 15 Dec 2016 09:39:30 +0100
Subject: [PATCH] gnu: leptonica: Update to 1.73.
* gnu/packages/image.scm (leptonica): Update to 1.73.
---
gnu/packages/image.scm | 54 +++++++++++++++++---------------------------------
1 file changed, 18 insertions(+), 36 deletions(-)
diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 487635d..126e615 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -329,28 +329,18 @@ the W3C's XML-based Scaleable Vector Graphic (SVG) format.")
(define-public leptonica
(package
(name "leptonica")
- (version "1.72")
+ (version "1.73")
(source
(origin
(method url-fetch)
(uri (string-append "http://www.leptonica.com/source/leptonica-"
version ".tar.gz"))
(sha256
- (base32 "0mhzvqs0im04y1cpcc1yma70hgdac1frf33h73m9z3356bfymmbr"))
- (modules '((guix build utils)))
- ;; zlib and openjpg should be under Libs, not Libs.private. See:
- ;; https://code.google.com/p/tesseract-ocr/issues/detail?id=1436
- (snippet
- '(substitute* "lept.pc.in"
- (("^(Libs\\.private: .*)@ZLIB_LIBS@(.*)" all pre post)
- (string-append pre post))
- (("^(Libs\\.private: .*)@JPEG_LIBS@(.*)" all pre post)
- (string-append pre post))
- (("^Libs: .*" all)
- (string-append all " @ZLIB_LIBS@ @JPEG_LIBS@"))))))
+ (base32 "1hdgb6lflj5gc3c37rac5nk38vr6qln3im9qjfpphysfcxf37r0r"))))
(build-system gnu-build-system)
- (native-inputs
- `(("gnuplot" ,gnuplot))) ;needed for test suite
+ ;; XXX Re-enable this when the test suite is re-enabled.
+ ;; (native-inputs
+ ;; `(("gnuplot" ,gnuplot))) ;needed for test suite
(inputs
`(("giflib" ,giflib)
("libjpeg" ,libjpeg)
@@ -358,31 +348,23 @@ the W3C's XML-based Scaleable Vector Graphic (SVG) format.")
("libtiff" ,libtiff)
("libwebp" ,libwebp)))
(propagated-inputs
+ ;; Linking a program with leptonica also requires these.
`(("openjpeg" ,openjpeg)
("zlib" ,zlib)))
(arguments
- '(#:parallel-tests? #f ; XXX: cause fpix1_reg to fail
- #:phases
+ '(#:phases
(modify-phases %standard-phases
- ;; Prevent make from trying to regenerate config.h.in.
- (add-after
- 'unpack 'set-config-h-in-file-time
- (lambda _
- (set-file-time "config/config.h.in" (stat "configure"))))
- (add-after
- 'unpack 'patch-reg-wrapper
- (lambda _
- (substitute* "prog/reg_wrapper.sh"
- ((" /bin/sh ")
- (string-append " " (which "sh") " "))
- (("which gnuplot") (which "gnuplot")))))
- (add-before
- 'check 'disable-failing-tests
- ;; XXX: 2 of 9 tests from webpio_reg fails.
- (lambda _
- (substitute* "prog/webpio_reg.c"
- ((".*DoWebpTest2.* 90.*") "")
- ((".*DoWebpTest2.* 100.*") "")))))))
+ (add-after 'unpack 'patch-reg-wrapper
+ (lambda _
+ (substitute* "prog/reg_wrapper.sh"
+ ((" /bin/sh ")
+ (string-append " " (which "sh") " "))
+ (("which gnuplot")
+ "true")))))
+ ;; All tests of 1.73 fail in Guix's build environment due to the bug:
+ ;; https://github.com/DanBloomberg/leptonica/issues/224
+ ;; XXX Enable tests in 1.74 as the bug is fixed upstream.
+ #:tests? #f))
(home-page "http://www.leptonica.com/")
(synopsis "Library and tools for image processing and analysis")
(description
--
2.10.2
============================================================
next reply other threads:[~2016-12-23 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 21:10 "Taylan Ulrich Bayırlı/Kammer" [this message]
2016-12-24 14:17 ` [PATCH] gnu: leptonica: Update to 1.73 Marius Bakke
2016-12-24 16:19 ` Taylan Ulrich Bayırlı/Kammer
2016-12-25 13:01 ` Marius Bakke
2016-12-25 19:54 ` Taylan Ulrich Bayırlı/Kammer
2016-12-27 16:20 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1giwdvy.fsf@gmail.com \
--to=taylanbayirli@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.