From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add opencascade-oce Date: Mon, 30 Jan 2017 10:26:33 +0100 Message-ID: <87d1f4gapi.fsf@gnu.org> References: <1484738618-3156-1-git-send-email-pgarlick@tourbillion-technology.com> <87k29s8bd3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <1484827276.2709.14.camel@tourbillion-technology.com> <87y3y461h8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87pojgla44.fsf@gnu.org> <1485446510.25569.39.camel@tourbillion-technology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cY8ER-0002mB-PG for guix-devel@gnu.org; Mon, 30 Jan 2017 04:26:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cY8EN-0004WI-S6 for guix-devel@gnu.org; Mon, 30 Jan 2017 04:26:39 -0500 In-Reply-To: <1485446510.25569.39.camel@tourbillion-technology.com> (Paul Garlick's message of "Thu, 26 Jan 2017 16:01:50 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Paul Garlick Cc: guix-devel@gnu.org Hi Paul, Paul Garlick skribis: > Also, there is an extra configuration flag required to successfully > build the DRAW libraries and executable. =C2=A0The '-UCMAKE_INSTALL_RPATH' > flag is required for the validate-runpath stage to succeed. =C2=A0This is= to > do with the way the global variable is initialized. =C2=A0There is a > distinction in CMake between lists and strings, which was new to me so > I will document it here. =C2=A0 > Essentially, if a variable is initialized as a single string it cannot > subsequently be overriden by a list of strings. =C2=A0The cmake instructi= ons > in OpenCascade (in adm/cmake/BuildToolKit.cmake) attempt to do this at > the install stage. =C2=A0The DRAW harness needs a RUNPATH including both > .../lib and .../lib/oce-0.17. =C2=A0With the standard definition of > CMAKE_INSTALL_RPATH (from cmake-build-system.scm) the substitution of > the INSTALL_RPATH property only includes the first string. > =C2=A0Consequently, the validate-runpath phase fails (error: library ... = not > in RUNPATH ...). =C2=A0The configuration flag -UCMAKE_INSTALL_RPATH unsets > the global variable and allows the opencascade cmake rules to do the > work instead, setting the RUNPATH correctly for each target. > On the subject of the 0.18 version, perhaps this could be the subject > of a separate patch. =C2=A0There could be an argument to just update in t= he > normal way (instead of having two packages at once). =C2=A0The issue is > related to the hardware requirements of recent versions of OpenGL. =C2=A0= It > is useful to start with 0.17 as this imposes the least restriction on > older graphics card. =C2=A0I can do some testing on the new version, later > on, to determine how important this is. I=E2=80=99ll let you decide. :-) > From a5f64ac9b488249027fc92c46d737d4572e57d02 Mon Sep 17 00:00:00 2001 > From: Paul Garlick > Date: Wed, 18 Jan 2017 10:01:36 +0000 > Subject: [PATCH] gnu: Add opencascade-oce > > * gnu/packages/maths.scm: Add opencascade-oce [...] > + (synopsis > + "Libraries for 3D modeling and numerical simulation") > + (description "OCE stands for Open CASCADE Community Edition. The pr= oject > +gathers patches/improvements/experiments contributed by users over the o= fficial > +Open CASCADE library.") I=E2=80=99ve changed the description to explain what Open CASCADE is, adjus= ted the commit log, and committed. Thank you! Ludo=E2=80=99.