From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1csnhV-0004hP-VO
	for guix-patches@gnu.org; Tue, 28 Mar 2017 05:46:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1csnhS-00032E-Tr
	for guix-patches@gnu.org; Tue, 28 Mar 2017 05:46:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50301)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1csnhS-000321-ML
	for guix-patches@gnu.org; Tue, 28 Mar 2017 05:46:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1csnhS-0007Wf-Fy
	for guix-patches@gnu.org; Tue, 28 Mar 2017 05:46:02 -0400
Subject: bug#26256: [PATCH 4/6] gnu: fio: Enable rbd support.
Resent-Message-ID: <handler.26256.B26256.149069433228887@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170325203017.14931-1-mbakke@fastmail.com>
	<20170325203017.14931-4-mbakke@fastmail.com> <87vaqvj5w6.fsf@gnu.org>
	<87vaquv09a.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Date: Tue, 28 Mar 2017 11:45:19 +0200
In-Reply-To: <87vaquv09a.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	(Marius Bakke's message of "Tue, 28 Mar 2017 00:10:57 +0200")
Message-ID: <87d1d17n0w.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26256@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> skribis:
>>
>>> * gnu/packages/benchmark.scm (fio)[inputs]: Add ceph:lib.
>>
>> Would be worth checking how this affects the closure size.  It=E2=80=99s=
 a
>> developer tool though, so I=E2=80=99d argue that it=E2=80=99s less of a =
problem if the
>> closure size is increased noticeably in this cases.
>
> ceph:lib increases fios closure size from 452.3 MiB to a good 738 MiB.
>
> However, by moving the fio auxiliary scripts to a separate output, I
> managed to get the baseline size down from 452.3 MiB to 75.3 MiB. See
> attached patch. WDYT?
>
> From b942036bef17a4eacfd7406a9a5130fd2255252d Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Tue, 28 Mar 2017 00:08:36 +0200
> Subject: [PATCH] gnu: fio: Install python scripts in separate output.
>
> * gnu/packages/benchmark.scm (fio)[outputs]: New field.
> [arguments]: Rename 'wrap-python-scripts' to 'move-outputs'. Keep wrapper.

[...]

> +         (add-after 'install 'move-outputs
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))
> +                   (utils (string-append (assoc-ref outputs "utils") "/b=
in")))

Add a comment explaining that this saves X MiB on the closure.

> +    (outputs '("out" "utils"))

Maybe s/utils/bin/ if there aren=E2=80=99t any other binaries, otherwise LG=
TM!

Thank you!

Ludo=E2=80=99.