From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 10/11] gnu: Add python-pkginfo.
Date: Mon, 18 Sep 2017 22:34:08 +0200
Message-ID: <87d16ng30f.fsf@gnu.org>
References: <20170911182242.7422-1-tipecaml@gmail.com>
	<20170911182242.7422-11-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1du2kD-0005GW-TT
	for guix-devel@gnu.org; Mon, 18 Sep 2017 16:34:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1du2k7-0005TO-Lj
	for guix-devel@gnu.org; Mon, 18 Sep 2017 16:34:17 -0400
In-Reply-To: <20170911182242.7422-11-tipecaml@gmail.com> (Cyril Roelandt's
	message of "Mon, 11 Sep 2017 20:22:41 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-pkginfo, python2-pkginfo): New variable=
s.

[...]

> +    (arguments
> +     ;; The tests are broken upstream.
> +     '(#:tests? #f))

If there=E2=80=99s a URL explaining this, please add it.

> +    (synopsis
> +      "Query metadatdata from sdists / bdists / installed packages.")

Rather:  =E2=80=9CQuery metadata from sdists, bdists, and installed package=
s=E2=80=9D

> +    (description
> +      "API to query the distutils metadata written in the PKG-INFO file =
inside a
> +source distriubtion (an sdist) or a binary distribution (e.g., created by
> +running bdist_egg).  It can also query the EGG-INFO directory of an inst=
alled
> +distribution, and the *.egg-info stored in a =E2=80=9Cdevelopment checko=
ut=E2=80=9D (e.g,
> +created by running setup.py develop).")

Please use @code, @file, etc. as appropriate.

Otherwise LGTM!