From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwkVL-00059Y-5n for guix-patches@gnu.org; Tue, 26 Sep 2017 03:42:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwkVG-0005tJ-Py for guix-patches@gnu.org; Tue, 26 Sep 2017 03:42:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwkVG-0005tA-MW for guix-patches@gnu.org; Tue, 26 Sep 2017 03:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dwkVG-0003pm-Gi for guix-patches@gnu.org; Tue, 26 Sep 2017 03:42:02 -0400 Subject: [bug#28586] [PATCH 2/2] gnu: Add Syncthing. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <5f9b36da2183c37cb24713472ea22921c0f48d36.1506285652.git.leo@famulari.name> <20170925182144.GA16527@jasmine.lan> <20170925192852.GA12757@jasmine.lan> Date: Tue, 26 Sep 2017 09:41:36 +0200 In-Reply-To: <20170925192852.GA12757@jasmine.lan> (Leo Famulari's message of "Mon, 25 Sep 2017 15:28:52 -0400") Message-ID: <87d16d3o0f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 28586@debbugs.gnu.org Heya! Leo Famulari skribis: > On Mon, Sep 25, 2017 at 02:21:44PM -0400, Leo Famulari wrote: >> This suggests to me that the Syncthing build process is not using the >> compiled objects of these packages but is instead trying to rebuild >> them. >>=20 >> So, perhaps something is not quite right with the go-build-system =E2=80= =94 I'm >> not sure. > > While debugging, I tried changing the go-build-system's build procedure > to this: > > ------ > (define* (build #:key import-path #:allow-other-keys) > "Build the package named by IMPORT-PATH." > (unless (zero? (system* "go" "install" "-v" import-path)) > (zero? (system* "go" "env"))))=20=20 > ------ Note that it should always return a Boolean: (or (zero? (system* "go" "install" =E2=80=A6)) (begin ;we failed but we want to print debugging info (system* "go" "env") #f)) > However, when it encounters a failure, it does not seem to run `go env`: > > ------ > [...] > /gnu/store/40m4imp31qkhl2yqvxm4dfaw0j6hgfr2-golang-github-com-golang-gro= upcache-lru-0.0.0-0.72d04f9/src/github.com/pkg/errors > /gnu/store/dn3hbj11bzk6ys3yj5k36k7a9fyg1zp8-golang-github-com-edsrzf-mma= p-go-0.0.0-0.0bce6a6/src/github.com/pkg/errors > /gnu/store/h36806f660r6p5xzwsc89zrbfnvi6nwi-golang-github-com-d4l3k-mess= agediff-1.1.0-0.29f32d8/src/github.com/pkg/errors > exit status 1 > exit status 1 > phase `build' failed after 1.9 seconds I think it just means that =E2=80=9Cgo env=E2=80=9D returned with exit code= 1, no? Ludo=E2=80=99. PS: Great to see =E2=80=98go-build-system=E2=80=99 coming!