[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Oleg Pykhalov]

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ccc8c6db5..49bcc8a8a 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5865,3 +5865,30 @@ displaying a tooltip at mouse position which allows users to easily show it.
 However, locating tooltip at arbitrary buffer position in window is not easy.
 This program provides such function to be used by other frontend programs.")
     (license license:gpl2+)))
+
+(define-public emacs-sr-speedbar
+  (package
+    (name "emacs-sr-speedbar")
+    (version "20161025")
+    (source
+     (origin
+       (method url-fetch)
+       (uri "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
+       (file-name (string-append "sr-speedbar-" version ".el"))
+       (sha256
+        (base32
+         "15kvl270a5xx1w5fjlrawslnpwyks2x17356xcr0idhv5xw2wn30"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
+    (synopsis "Same frame speedbar")
+    (description "Speedbar in same Emacs frame.  Below are commands you can use:
+@itemize
+@item @code{sr-speedbar-open} Open sr-speedbar window.
+@item @code{sr-speedbar-close} Close sr-speedbar window.
+@item @code{sr-speedbar-toggle} Toggle sr-speedbar window.
+@item @code{sr-speedbar-select-window} Select sr-speedbar window.
+@item @code{sr-speedbar-refresh-turn-on} Turn on refresh speedbar content.
+@item @code{sr-speedbar-refresh-turn-off} Turn off refresh speedbar content.
+@item @code{sr-speedbar-refresh-toggle} Toggle refresh speedbar content.
+@end itemize\n")
+    (license license:gpl3+)))

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Jonathan Brielmaier]

I think you shouldn't include the exact commands into the description.

"Show the speedbar in the same Emacs frame or in an extra window.
Customize the inital width of the speedbar."

Maybe that is better.

Am 23.08.2017 um 21:55 schrieb Oleg Pykhalov:
> +    (description "Speedbar in same Emacs frame.  Below are commands you can use:
> +@itemize
> +@item @code{sr-speedbar-open} Open sr-speedbar window.
> +@item @code{sr-speedbar-close} Close sr-speedbar window.
> +@item @code{sr-speedbar-toggle} Toggle sr-speedbar window.
> +@item @code{sr-speedbar-select-window} Select sr-speedbar window.
> +@item @code{sr-speedbar-refresh-turn-on} Turn on refresh speedbar content.
> +@item @code{sr-speedbar-refresh-turn-off} Turn off refresh speedbar content.
> +@item @code{sr-speedbar-refresh-toggle} Toggle refresh speedbar content.
> +@end itemize\n")

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Hello Jonathan,

Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:

> I think you shouldn't include the exact commands into the description.
>
> "Show the speedbar in the same Emacs frame or in an extra window.
> Customize the inital width of the speedbar."
>
> Maybe that is better.
>
> Am 23.08.2017 um 21:55 schrieb Oleg Pykhalov:
>> +    (description "Speedbar in same Emacs frame.  Below are commands you can use:
>> +@itemize
>> +@item @code{sr-speedbar-open} Open sr-speedbar window.
>> +@item @code{sr-speedbar-close} Close sr-speedbar window.
>> +@item @code{sr-speedbar-toggle} Toggle sr-speedbar window.
>> +@item @code{sr-speedbar-select-window} Select sr-speedbar window.
>> +@item @code{sr-speedbar-refresh-turn-on} Turn on refresh speedbar content.
>> +@item @code{sr-speedbar-refresh-turn-off} Turn off refresh speedbar content.
>> +@item @code{sr-speedbar-refresh-toggle} Toggle refresh speedbar content.
>> +@end itemize\n")


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Change synopsis and description. --]
[-- Type: text/x-patch, Size: 1525 bytes --]

From b4a8728fd752d2a245258e258e72c9c5fcfcb426 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 23 Aug 2017 22:30:19 +0300
Subject: [PATCH] gnu: Add emacs-sr-speedbar.

* gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.
---
 gnu/packages/emacs.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ccc8c6db5..13ee58231 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5865,3 +5865,22 @@ displaying a tooltip at mouse position which allows users to easily show it.
 However, locating tooltip at arbitrary buffer position in window is not easy.
 This program provides such function to be used by other frontend programs.")
     (license license:gpl2+)))
+
+(define-public emacs-sr-speedbar
+  (package
+    (name "emacs-sr-speedbar")
+    (version "20161025")
+    (source
+     (origin
+       (method url-fetch)
+       (uri "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
+       (file-name (string-append "sr-speedbar-" version ".el"))
+       (sha256
+        (base32
+         "15kvl270a5xx1w5fjlrawslnpwyks2x17356xcr0idhv5xw2wn30"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
+    (synopsis "Same frame Emacs @code{speedbar}")
+    (description "Show the speedbar in the same Emacs frame or in an extra
+window.  Customize the inital width of the speedbar.")
+    (license license:gpl3+)))
-- 
2.14.1

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Ludovic Courtès]

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:
>
>> I think you shouldn't include the exact commands into the description.
>>
>> "Show the speedbar in the same Emacs frame or in an extra window.
>> Customize the inital width of the speedbar."
>>
>> Maybe that is better.

Agreed.

There’s one problem left, though:

> From b4a8728fd752d2a245258e258e72c9c5fcfcb426 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Wed, 23 Aug 2017 22:30:19 +0300
> Subject: [PATCH] gnu: Add emacs-sr-speedbar.
>
> * gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.

[...]

> +     (origin
> +       (method url-fetch)
> +       (uri "https://www.emacswiki.org/emacs/download/sr-speedbar.el")

This URL is unversioned, so it’ll break next time the file is updated in
place.  Is there an alternate URL available?

Thanks,
Ludo’.

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Alex Kost]

Ludovic Courtès (2017-08-31 14:50 +0200) wrote:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust@gmail.com> skribis:
[...]
>> From b4a8728fd752d2a245258e258e72c9c5fcfcb426 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Wed, 23 Aug 2017 22:30:19 +0300
>> Subject: [PATCH] gnu: Add emacs-sr-speedbar.
>>
>> * gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.
>
> [...]
>
>> +     (origin
>> +       (method url-fetch)
>> +       (uri "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
>
> This URL is unversioned, so it’ll break next time the file is updated in
> place.  Is there an alternate URL available?

MELPA people also don't like sources from emacswiki and use the
following source instead:

  https://github.com/emacsorphanage/sr-speedbar

I think it is a good substitution for the original emacswiki page.

-- 
Alex

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Oleg Pykhalov]

Hello Alex,

Alex Kost <alezost@gmail.com> writes:

> Ludovic Courtès (2017-08-31 14:50 +0200) wrote:
>
>> Hi Oleg,
>>
>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
> [...]
>>> From b4a8728fd752d2a245258e258e72c9c5fcfcb426 Mon Sep 17 00:00:00 2001
>>> From: Oleg Pykhalov <go.wigust@gmail.com>
>>> Date: Wed, 23 Aug 2017 22:30:19 +0300
>>> Subject: [PATCH] gnu: Add emacs-sr-speedbar.
>>>
>>> * gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.
>>
>> [...]
>>
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
>>
>> This URL is unversioned, so it’ll break next time the file is updated in
>> place.  Is there an alternate URL available?

We could make our own versioning, couldn't we?  Like in (guix-edit
"emacs-goto-chg").

> MELPA people also don't like sources from emacswiki and use the
> following source instead:
>
>   https://github.com/emacsorphanage/sr-speedbar
>
> I think it is a good substitution for the original emacswiki page.

Melpa people pull all from master.  Their sr-speedbar version is
20161025.131, but their release tarball version from which they pull is
20140914.2339.

So, I see two solutions: add a comment “There is no versioned source.”
like in (guix-edit "emacs-goto-chg") or pull from github git commit.

https://github.com/emacsorphanage/sr-speedbar doesn't have Issue tab.
https://emacsmirror.net/stats/emacsorphanage.html doesn't have any
contact info except author name.  The only way for me to ask a developer
a new release tarball is find another repository with opened Issue tab.

What do you think?

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Alex Kost]

Oleg Pykhalov (2017-09-17 12:03 +0300) wrote:

> Hello Alex,
>
> Alex Kost <alezost@gmail.com> writes:
>
>> Ludovic Courtès (2017-08-31 14:50 +0200) wrote:
>>
>>> Hi Oleg,
>>>
>>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>> [...]
>>>> From b4a8728fd752d2a245258e258e72c9c5fcfcb426 Mon Sep 17 00:00:00 2001
>>>> From: Oleg Pykhalov <go.wigust@gmail.com>
>>>> Date: Wed, 23 Aug 2017 22:30:19 +0300
>>>> Subject: [PATCH] gnu: Add emacs-sr-speedbar.
>>>>
>>>> * gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.
>>>
>>> [...]
>>>
>>>> +     (origin
>>>> +       (method url-fetch)
>>>> +       (uri "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
>>>
>>> This URL is unversioned, so it’ll break next time the file is updated in
>>> place.  Is there an alternate URL available?
>
> We could make our own versioning, couldn't we?  Like in (guix-edit
> "emacs-goto-chg").

Sorry, I don't understand what you mean here.  The problem with an
unversioned source is the following: once the source is updated in
place, its hash is changed and our package could not be built anymore.

>> MELPA people also don't like sources from emacswiki and use the
>> following source instead:
>>
>>   https://github.com/emacsorphanage/sr-speedbar
>>
>> I think it is a good substitution for the original emacswiki page.
>
> Melpa people pull all from master.  Their sr-speedbar version is
> 20161025.131, but their release tarball version from which they pull is
> 20140914.2339.

Well yeah, but there were only 2 minor changes (compilation warnings
fixes) between these 2 years:

  https://github.com/emacsorphanage/sr-speedbar/commits/master

> So, I see two solutions: add a comment “There is no versioned source.”
> like in (guix-edit "emacs-goto-chg") or pull from github git commit.

I vote for using the emacsorphanage source (either git-fetch or using
the latest release are fine for me).

> https://github.com/emacsorphanage/sr-speedbar doesn't have Issue tab.
> https://emacsmirror.net/stats/emacsorphanage.html doesn't have any
> contact info except author name.  The only way for me to ask a developer
> a new release tarball is find another repository with opened Issue tab.

Jonas Bernoulli is "tarsius" on github.  He is the person who makes a
lot of cool stuff in the Emacs world (like emacsmirror, emacsorphanage
and magit).  I wouldn't bother him about making the new release just for
2 insignificant commits in the repo.

Just for the info, there was an interesting message by tarsius related
to Emacsmirror (orphanage) and Emacswiki:

  https://github.com/melpa/melpa/issues/2342#issuecomment-291922427

-- 
Alex

[bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

Hello Alex,

Alex Kost <alezost@gmail.com> writes:

>> We could make our own versioning, couldn't we?  Like in (guix-edit
>> "emacs-goto-chg").
>
> Sorry, I don't understand what you mean here.  The problem with an
> unversioned source is the following: once the source is updated in
> place, its hash is changed and our package could not be built anymore.

There are packages with version like a string of 0.0.0 plus revision
plus 7 first commit characters.

> Well yeah, but there were only 2 minor changes (compilation warnings
> fixes) between these 2 years:
>
>   https://github.com/emacsorphanage/sr-speedbar/commits/master

Ah, sorry.  Should probably check myself.

> I vote for using the emacsorphanage source (either git-fetch or using
> the latest release are fine for me).

Agreed.

> Jonas Bernoulli is "tarsius" on github.  He is the person who makes a
> lot of cool stuff in the Emacs world (like emacsmirror, emacsorphanage
> and magit).  I wouldn't bother him about making the new release just for
> 2 insignificant commits in the repo.

Yes, not great idea.

> Just for the info, there was an interesting message by tarsius related
> to Emacsmirror (orphanage) and Emacswiki:
>
>   https://github.com/melpa/melpa/issues/2342#issuecomment-291922427

Thanks for notice.

Here is a new patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-sr-speedbar.patch --]
[-- Type: text/x-patch, Size: 1537 bytes --]

From bdd48b1c3c1fbad28ae269e68a2080890c4d77d4 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 23 Sep 2017 05:10:26 +0300
Subject: [PATCH] gnu: Add emacs-sr-speedbar.

* gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7a6f16c1e..56bd81d80 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2079,6 +2079,27 @@ read from small to large monitors by using colors, a prefix feature, and smart
 truncation.")
     (license license:gpl2+)))
 
+(define-public emacs-sr-speedbar
+  (package
+    (name "emacs-sr-speedbar")
+    (version "20140914.2339")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/emacsorphanage/sr-speedbar/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "15xwwc6kgvmk4wdhx1j8w6m6ivxvc94028ppgdpa2m51a8c9vjm9"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/download/sr-speedbar.el")
+    (synopsis "Same frame Emacs @code{speedbar}")
+    (description "Show the speedbar in the same Emacs frame or in an extra
+window.  Customize the inital width of the speedbar.")
+    (license license:gpl3+)))
+
 (define-public emacs-shell-switcher
   (package
     (name "emacs-shell-switcher")
-- 
2.14.1

bug#28210: [PATCH] gnu: Add emacs-sr-speedbar.

[Alex Kost]

Oleg Pykhalov (2017-09-23 05:18 +0300) wrote:

> From bdd48b1c3c1fbad28ae269e68a2080890c4d77d4 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 23 Sep 2017 05:10:26 +0300
> Subject: [PATCH] gnu: Add emacs-sr-speedbar.
>
> * gnu/packages/emacs.scm (emacs-sr-speedbar): New variable.
> ---
>  gnu/packages/emacs.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 7a6f16c1e..56bd81d80 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -2079,6 +2079,27 @@ read from small to large monitors by using colors, a prefix feature, and smart
>  truncation.")
>      (license license:gpl2+)))
>  
> +(define-public emacs-sr-speedbar
> +  (package
> +    (name "emacs-sr-speedbar")
> +    (version "20140914.2339")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/emacsorphanage/sr-speedbar/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "15xwwc6kgvmk4wdhx1j8w6m6ivxvc94028ppgdpa2m51a8c9vjm9"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://www.emacswiki.org/emacs/download/sr-speedbar.el")

I changed it to <https://www.emacswiki.org/emacs/SrSpeedbar>.  I think
it is more "home-pagy" than just the source code.

> +    (synopsis "Same frame Emacs @code{speedbar}")
> +    (description "Show the speedbar in the same Emacs frame or in an extra
> +window.  Customize the inital width of the speedbar.")
typo:                     initial

> +    (license license:gpl3+)))

I have rephrased the description a bit and applied¹, thank you!

Please make sure your patches can be applied to the master branch of the
guix git repo.  I often have problems with your patches (git complains
with: "Patch format detection failed", so I have to make some manual
interventions).  I don't know, maybe you make your patches on an
outdated git checkout or in a separate branch that differs from master a
lot.  Just a friendly note :-)

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=69b498a162e9c1fca459bf0737343619e6c7de96

-- 
Alex

[bug#28210] closed (Re: [bug#28210] [PATCH] gnu: Add emacs-sr-speedbar.)

[Oleg Pykhalov]

help-debbugs@gnu.org (GNU bug Tracking System) writes:

> Please make sure your patches can be applied to the master branch of the
> guix git repo.  I often have problems with your patches (git complains
> with: "Patch format detection failed", so I have to make some manual
> interventions).  I don't know, maybe you make your patches on an
> outdated git checkout or in a separate branch that differs from master a
> lot.  Just a friendly note :-)

Hm.  I switched to rebasing onto origin/master some time ago.  I have 2
commits from myself on top of origin/master.

Before sending a patch, I rearrange them with rebasing, so patch commit
be on top of origin/master.  Probably I forgot to do this last time,
sorry.

I probably need to script a test for merging a patch into origin/master
before sending.