From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGgcf-0004lF-Dn
	for guix-patches@gnu.org; Mon, 20 Nov 2017 02:36:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGgcc-0003B5-Ag
	for guix-patches@gnu.org; Mon, 20 Nov 2017 02:36:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:39502)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eGgcc-0003B1-7Z
	for guix-patches@gnu.org; Mon, 20 Nov 2017 02:36:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGgcc-000884-1n
	for guix-patches@gnu.org; Mon, 20 Nov 2017 02:36:02 -0500
Subject: [bug#29359] [PATCH 30/31] gnu: Add java-xmlunit.
Resent-Message-ID: <handler.29359.B29359.151116332931204@debbugs.gnu.org>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-30-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171119175805.902-30-julien@lepiller.eu>
Date: Mon, 20 Nov 2017 08:35:16 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <87d14dxv0r.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 29359@debbugs.gnu.org


Julien Lepiller <julien@lepiller.eu> writes:

> * gnu/packages/java.scm (java-xmlunit): New variable.
[=E2=80=A6]
> +
> +(define java-xmlunit-test-resources
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +           (url "https://github.com/xmlunit/test-resources.git")
> +           (commit "a590d2ae865c3e0455691d76ba8eefccc2215aec")))
> +    (file-name "java-xmlunit-test-resources")
> +    (sha256
> +     (base32
> +      "0r0glj37pg5l868yjz78gckr91cs8fysxxbp9p328dssssi91agr"))))

I=E2=80=99d prefer if this were placed inline as part of the java-xmlunit
inputs, instead of making a top-level definition.

The rest looks good to me.

--=20
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net