From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#29492: tests/guix-system.sh failure on unbound variable check Date: Sat, 02 Dec 2017 10:59:57 +0100 Message-ID: <87d13x30wy.fsf@gnu.org> References: <87vahs5bh2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL4bZ-0007nF-4o for bug-guix@gnu.org; Sat, 02 Dec 2017 05:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL4bW-0008Ru-1s for bug-guix@gnu.org; Sat, 02 Dec 2017 05:01:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eL4bV-0008Ra-VM for bug-guix@gnu.org; Sat, 02 Dec 2017 05:01:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eL4bV-00012n-M6 for bug-guix@gnu.org; Sat, 02 Dec 2017 05:01:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: (Eric Bavier's message of "Fri, 1 Dec 2017 23:28:39 +0000") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Eric Bavier Cc: "'29492@debbugs.gnu.org'" <29492@debbugs.gnu.org> Eric Bavier skribis: >> -----Original Message----- >> From: Ludovic Court=C3=A8s [mailto:ludo@gnu.org] >> Sent: Thursday, November 30, 2017 4:04 AM >> To: Eric Bavier >> Cc: 29492@debbugs.gnu.org >> Subject: Re: bug#29492: tests/guix-system.sh failure on unbound variable >> check >>=20 >> Hi Eric, >>=20 >> Eric Bavier skribis: >>=20 >> > Latest guix master (2cdf78df2d3d5d88c7e6908754233cf37cce1e61) fails >> tests/guix-system.sh for me, on line 128. This seems to be caused by the >> fact that the error output contains a multi-character column number: >> > >> > ``` >> > /tmp/bavier/tmpfile:9:14: In procedure #: >> > /tmp/bavier/tmpfile:9:14: GRUB-config: unbound variable >> > hint: Did you forget a `use-modules' form? >>=20 >> I suppose that=E2=80=99s with Guile 2.0, right? > > Right, 2.0.14. > >> So the patch would become: > > diff --git a/tests/guix-system.sh b/tests/guix-system.sh > index 4bb866adf..eaa0c4332 100644 > --- a/tests/guix-system.sh > +++ b/tests/guix-system.sh > @@ -125,7 +125,8 @@ else > # See . > grep "$tmpfile:[49]:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfil= e" > else > - grep "$tmpfile:9:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile" > + # With Guile 2.0.14 the error is reported on line 14 (the last line). > + grep "$tmpfile:9:[0-9]\+: GRUB-config.*[Uu]nbound variable" "$errorfile" > fi > fi > > No, at *column* 14. Which I believe is the desired result, right? Chara= cter 14 is the '(', the 'GRUB-config symbol itself starts at character 15. = But now I wonder whether we should be using a regex for that anyhow. Do = we expect the column number to change ever? We don=E2=80=99t, but sometimes location info is not as precise as we=E2=80= =99d like. > I think it would be fine to fix the regex for Guile 2.0 only, but once th= e bug affecting 2.2 is fixed, it'll need to be applied there too. Maybe it= would make sense to fix both at the same time. Yes, you=E2=80=99re right, it=E2=80=99s better to fix both. Feel free to push. Thank you! Ludo=E2=80=99.