From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eNF7Z-0008Fc-IS
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:39:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eNF7W-00088B-E7
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:39:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42652)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eNF7W-000887-94
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:39:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eNF7W-0008IT-09
	for guix-patches@gnu.org; Fri, 08 Dec 2017 04:39:02 -0500
Subject: [bug#29409] [PATCH] build: vm: Use qemu drive device parameter.
Resent-Message-ID: <handler.29409.B29409.151272593331878@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <877euhtjkj.fsf@gmail.com>
	<1512408912-21174-1-git-send-email-m.othacehe@gmail.com>
Date: Fri, 08 Dec 2017 10:38:49 +0100
In-Reply-To: <1512408912-21174-1-git-send-email-m.othacehe@gmail.com>
	(m. othacehe's message of "Mon, 4 Dec 2017 18:35:12 +0100")
Message-ID: <87d13p36fq.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: m.othacehe@gmail.com
Cc: 29409@debbugs.gnu.org

m.othacehe@gmail.com skribis:

> From: Mathieu Othacehe <m.othacehe@gmail.com>
>
> * gnu/build/vm.scm (load-in-linux-vm): As per network arguments, use devi=
ce
> parameter to define drive device.
> ---
>  gnu/build/vm.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
> index 9e868f6..96c57ab 100644
> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -126,10 +126,11 @@ the #:references-graphs parameter of 'derivation'."
>                    "-initrd" initrd
>                    "-append" (string-append "console=3DttyS0 --load=3D"
>                                             builder)
> +                  "-device" "virtio-blk,drive=3Dhd"
>                    (append
>                     (if make-disk-image?
> -                       `("-drive" ,(string-append "file=3D" output
> -                                                  ",if=3Dvirtio"))
> +                       `("-drive" ,(string-append "if=3Dnone,file=3D" ou=
tput
> +                                                  ",id=3Dhd"))

Is there a difference between =E2=80=98virtio=E2=80=99 and =E2=80=98virtio-=
blk=E2=80=99?

If confess I always have a hard time parsing QEMU=E2=80=99s command-line
options, but as long as it still works, it LGTM.  :-)

Thanks,
Ludo=E2=80=99.