From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQKar-0005gt-Pw for guix-patches@gnu.org; Sat, 16 Dec 2017 17:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQKao-0004PR-Km for guix-patches@gnu.org; Sat, 16 Dec 2017 17:06:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQKao-0004Ou-GA for guix-patches@gnu.org; Sat, 16 Dec 2017 17:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQKao-0004eS-6F for guix-patches@gnu.org; Sat, 16 Dec 2017 17:06:02 -0500 Subject: [bug#29732] [PATCH 0/1] Add a DHCP daemon service Resent-Message-ID: References: <20171216083528.2081-1-cmmarusich@gmail.com> From: Christopher Baines In-reply-to: <20171216083528.2081-1-cmmarusich@gmail.com> Date: Sat, 16 Dec 2017 22:05:16 +0000 Message-ID: <87d13epbvn.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 29732@debbugs.gnu.org Chris Marusich writes: > Hi, > > The following patch adds a DHCP daemon service. It applies cleanly to > commit 341bddb31542d03bef35b1234e6e9466be337798. > > I haven't found the time to add system tests yet, and I'm not sure how > easy it would be to do that (wouldn't such a system test require at > least two marionetted VMs? Or is it possible to do it with just > one?). Any thoughts about how to do that would be welcome. > > In addition, I decided not to provide any kind of Guile scheme > representation for the daemon's config file, since that was the > quickest way for me to get a working DHCP daemon service. I think it > makes sense to let a user specify a config file explicitly, like this > patch does. I also think it would be neat to provide a way to > configure the daemon in Guile scheme, like we do for other services > such as openssh. Any thoughts on this front would be welcome, too. > > Chris Marusich (1): > services: Add dhcpd-service-type and . > > doc/guix.texi | 17 +++++++++++ > gnu/services/networking.scm | 72 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 89 insertions(+) I had a quick look at the patch, and it looks good to me. A system test would be nice. I think the important thing to test is the Guix part of the service, so if it's possible to get it to start on a VM, I think just checking the status of the shepherd service would be a good test. I think not providing a Guile configuration approach is fine as well. Thanks, Chris