From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZjpX-0002o5-LJ
	for guix-patches@gnu.org; Thu, 11 Jan 2018 15:52:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZjpS-0007Bh-QX
	for guix-patches@gnu.org; Thu, 11 Jan 2018 15:52:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:44622)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eZjpS-0007BK-MZ
	for guix-patches@gnu.org; Thu, 11 Jan 2018 15:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZjpS-0008Be-FP
	for guix-patches@gnu.org; Thu, 11 Jan 2018 15:52:02 -0500
Subject: [bug#29741] [PATCH 2/2] gnu: services: web: Add service for httpd.
In-Reply-To: <87efnuph3l.fsf@cbaines.net>
Resent-Message-ID: <handler.29741.B29741.151570391631457@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Date: Thu, 11 Jan 2018 10:46:13 +0100
References: <87zi6gtkhx.fsf@gnu.org> <20171224180157.21873-1-mail@cbaines.net>
	<20171224180157.21873-2-mail@cbaines.net>
Message-ID: <87d12gp193.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 29741@debbugs.gnu.org

Hi Chris!

Sorry for the delay.

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/services/web.scm (<httpd-module>,
>   <httpd-config-file>, <httpd-virtualhost>
>   <httpd-configuration>): New record types.
>   (%default-httpd-modules, %httpd-accounts,
>   httpd-service-type): New variables.
>   (httpd-shepherd-services, httpd-activation,
>   httpd-process-extensions): New procedures.
> * gnu/tests/web.scm (run-httpd-test): New procedure.
>   (%httpd-os, %tests-httpd): New variables.
> * doc/guix.texi (Web Services): Document the Apache HTTP Server.

[...]

> +The @code{(gnu services web)} module provides the Apache HTTP Server,
> +the nginx web server, and also a fastcgi wrapper daemon.
> +
> +@subsubheading Apache HTTP Server
> +
> +@deffn {Scheme Variable} httpd-service-type
> +Service type for the @uref{https://httpd.apache.org/,Apache HTTP}
> +server.  The value for this service type is a @code{https-configuration}
        ^
Maybe add =E2=80=9C(@dfn{httpd})=E2=80=9D.

Apart from this super-nitpicky comment, this LGTM!  :-)

Thank you,
Ludo=E2=80=99.