From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: proposal: with-file-writeable Date: Fri, 16 Feb 2018 09:40:15 +0100 Message-ID: <87d115tjio.fsf@gnu.org> References: <87wozfp2wk.fsf@gnu.org> <878tbuwd6y.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1embZ7-0001gp-O0 for guix-devel@gnu.org; Fri, 16 Feb 2018 03:40:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1embZ4-0004OQ-Jj for guix-devel@gnu.org; Fri, 16 Feb 2018 03:40:21 -0500 Received: from hera.aquilenet.fr ([2a0c:e300::1]:40098) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1embZ4-0004Lm-Bi for guix-devel@gnu.org; Fri, 16 Feb 2018 03:40:18 -0500 In-Reply-To: <878tbuwd6y.fsf@fastmail.com> (Marius Bakke's message of "Thu, 15 Feb 2018 15:16:21 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: Guix-devel Marius Bakke skribis: > G=C3=A1bor Boskovits writes: > >> Ok, the keep it this way. Another question, this came up, as >> I was trying to find a nice solution to reset-gzip-timestamps failing. >> I got different pieces of advice if I should reset the permissions after >> resetting the timestamp, but I'm still not sure. It seems that the easie= st >> way to this would be to just add a call to make-file-writable to the pha= se >> at the beginning, as we finally end up with a read-only one in the store >> anyway. I feel that reseting the permissions is unneccesary additional >> complexity. WDYT? > > In the "strip" phase we already call "make-file-writeable" > unconditionally, so doing it in reset-gzip-permissions as well should be > okay I think. Right, especially if this affects a number of packages already. Ludo=E2=80=99.