From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyXNv-00025g-43 for guix-patches@gnu.org; Wed, 21 Mar 2018 02:38:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyXNq-0006ia-KG for guix-patches@gnu.org; Wed, 21 Mar 2018 02:38:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36861) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyXNq-0006iN-EY for guix-patches@gnu.org; Wed, 21 Mar 2018 02:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyXNq-0002O0-6P for guix-patches@gnu.org; Wed, 21 Mar 2018 02:38:02 -0400 Subject: [bug#30885] Submitting Patch File for r-catdap Package Description for CRAN package Resent-Message-ID: References: From: Ricardo Wurmus In-reply-to: Date: Wed, 21 Mar 2018 07:36:11 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87d0zyc4v8.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Sahithi Yarlagadda Cc: 30885@debbugs.gnu.org Hi Sahithi, thanks for the patch! > + > +(define-public r-catdap > + (package > + (name "r-catdap") > + (version "1.3.4") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "catdap" version)) > + (sha256 > + (base32 > + "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2")))) > + (build-system r-build-system) > + (home-page "https://cran.r-project.org/web/packages/catdap/") > + (synopsis "Categorical data analysis program package") > + (description > + "Categorical data analysis by AIC. The methodology is described in > +Sakamoto (1992) @url{https://www.springer.com/in/book/9780792314295}") Please use full sentences in the description. In this case I went to the home page and downloaded the reference manual, which contains this sentence: =E2=80=9CThis package provides functions for analyzing multivariate data. Dependencies of the distribution of specified variable (response variable) to other variables (explanatory variables) are derived and evaluated by AIC (Akaike Information Criterion).=E2=80=9D This is a better description based on that sentence: This package provides functions for analyzing multivariate data. Dependencies of the distribution of the specified variable (response variable) to other variables (explanatory variables) are derived and evaluated by the @dfn{Akaike Information Criterion} (AIC). =E2=80=9C@dfn=E2=80=9D is used for definitions. > + ;; Any GPL version. > + (license license:gpl2+))) The comment is incorrect. The home page says: License:=09GPL-2 | GPL-3 [expanded from: GPL (=E2=89=A5 2)] This means it is actually GPLv2+. > + > + > + > + > + > + > + > + > + > + > + > + Please don=E2=80=99t add so many empty lines at the end :) Could you please send an updated patch as a reply to this message? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net