all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
@ 2018-04-03 14:23 Pierre Neidhardt
  2018-04-03 14:28 ` Pierre Neidhardt
  2018-04-04 11:56 ` bug#31046: " Ludovic Courtès
  0 siblings, 2 replies; 5+ messages in thread
From: Pierre Neidhardt @ 2018-04-03 14:23 UTC (permalink / raw)
  To: 31046

* gnu/packages/mp3.scm (chromaprint): Build fpcalc
---
 gnu/packages/mp3.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 6dc58e2cc..f57ebf575 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -508,6 +508,7 @@ command-line tool.")
     (arguments
      `(#:tests? #f ; tests require googletest *sources*
        ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
+       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
        #:test-target "check"))
     (inputs
      ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
  2018-04-03 14:23 [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc Pierre Neidhardt
@ 2018-04-03 14:28 ` Pierre Neidhardt
  2018-04-04 11:56 ` bug#31046: " Ludovic Courtès
  1 sibling, 0 replies; 5+ messages in thread
From: Pierre Neidhardt @ 2018-04-03 14:28 UTC (permalink / raw)
  To: 31046

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]


Toggle on the build of fpcalc, a commandline tool to compute the
fingerprint of audio files.

It's less than 40kb and does not require additional dependencies.
The size of the closure (as returned by ~guix size chromaprint~) is
510.3 MB, just like before the patch.

Considering how light it is, I don't think it's worth making a separate
output.

--
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#31046: [PATCH] gnu: chromaprint: Build fpcalc
  2018-04-03 14:23 [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc Pierre Neidhardt
  2018-04-03 14:28 ` Pierre Neidhardt
@ 2018-04-04 11:56 ` Ludovic Courtès
  2018-04-04 13:23   ` [bug#31046] " Pierre Neidhardt
  1 sibling, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2018-04-04 11:56 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 31046-done

Hello,

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
>  gnu/packages/mp3.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
>      (arguments
>       `(#:tests? #f ; tests require googletest *sources*
>         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc

[...]

> It's less than 40kb and does not require additional dependencies.
> The size of the closure (as returned by ~guix size chromaprint~) is
> 510.3 MB, just like before the patch.
>
> Considering how light it is, I don't think it's worth making a separate
> output.

Agreed.

I slightly adjusted the commit log to match the conventions and
committed.  Thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
  2018-04-04 11:56 ` bug#31046: " Ludovic Courtès
@ 2018-04-04 13:23   ` Pierre Neidhardt
  2018-04-04 14:06     ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Pierre Neidhardt @ 2018-04-04 13:23 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 31046-done

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> I slightly adjusted the commit log to match the conventions and
> committed.  Thank you!

Thank you.

I'm a bit confused about the log conventions although I've read the GNU
standards.  Are there some unwritten rules?

Maybe it's just a matter of getting use to the change log :)

--
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
  2018-04-04 13:23   ` [bug#31046] " Pierre Neidhardt
@ 2018-04-04 14:06     ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2018-04-04 14:06 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 31046-done

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> I slightly adjusted the commit log to match the conventions and
>> committed.  Thank you!
>
> Thank you.
>
> I'm a bit confused about the log conventions although I've read the GNU
> standards.  Are there some unwritten rules?

I think about everything is written down, maybe there are actually too
many written rules.  :-)

> Maybe it's just a matter of getting use to the change log :)

Yeah.  I’d suggest looking at past commits when in doubt.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-04-04 14:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-03 14:23 [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc Pierre Neidhardt
2018-04-03 14:28 ` Pierre Neidhardt
2018-04-04 11:56 ` bug#31046: " Ludovic Courtès
2018-04-04 13:23   ` [bug#31046] " Pierre Neidhardt
2018-04-04 14:06     ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.