Help needed to update VLC to 3.0.3 on the master branch

Help needed to update VLC to 3.0.3 on the master branch

[Mark H Weaver]

Hello Guix,

I just pushed a major VLC update to the 'core-updates' branch, commit
76277052939524d1ea3394f83739f06efd0dd8ae.  I pushed it to 'core-updates'
because I've been living on that branch for months, and so it's the only
branch that I can easily test for.

However, I strongly suspect that the old VLC on master, and the old
ffmpeg-2.8 that it depends on, are most likely a security risk.

So, I would be grateful if someone could cherry-pick this commit to
'master', do some basic testing on it, and then push it on my behalf if
it works.

Many thanks to Roel Janssen <roel@gnu.org> for his invaluable help on
this commit!

       Mark

Re: Help needed to update VLC to 3.0.3 on the master branch

[Clément Lassieur]

Hi Mark,

I just tested it and it works.

With this output though:

--8<---------------cut here---------------start------------->8---
[0000000001d03880] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-clement'
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-clement'
[0000000001cd23d0] main playlist: playlist is empty
Non-native QFileDialog supports only local files
Non-native QFileDialog supports only local files
Non-native QFileDialog supports only local files
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /gnu/store/9hddxnv7q3q819axyw0yngzppmrgmjfi-mesa-17.3.8/lib/dri/i965_drv_video.so
libva info: va_openDriver() returns -1
[00007f2110001f60] glconv_vaapi_x11 gl error: vaInitialize: unknown libva error
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /gnu/store/9hddxnv7q3q819axyw0yngzppmrgmjfi-mesa-17.3.8/lib/dri/i965_drv_video.so
libva info: va_openDriver() returns -1
[00007f2110001f60] glconv_vaapi_drm gl error: vaInitialize: unknown libva error
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 1
libva error: va_getDriverName() failed with operation failed,driver_name=i965
[00007f2110001f60] glconv_vaapi_drm gl error: vaInitialize: operation failed
Failed to open VDPAU backend libvdpau_va_gl.so: cannot open shared object file: No such file or directory
QObject::~QObject: Timers cannot be stopped from another thread
--8<---------------cut here---------------end--------------->8---

I can push it on your behalf if you tell me it's ok.

Clément

Re: Help needed to update VLC to 3.0.3 on the master branch

[Mark H Weaver]

Hi Clément,

Clément Lassieur <clement@lassieur.org> writes:
> I just tested it and it works.

Great, thank you!

> With this output though:
>
> [0000000001d03880] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
> QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-clement'
> QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-clement'
> [0000000001cd23d0] main playlist: playlist is empty
> Non-native QFileDialog supports only local files
> Non-native QFileDialog supports only local files
> Non-native QFileDialog supports only local files
> libva info: VA-API version 1.1.0
> libva info: va_getDriverName() returns 0
> libva info: Trying to open /gnu/store/9hddxnv7q3q819axyw0yngzppmrgmjfi-mesa-17.3.8/lib/dri/i965_drv_video.so
> libva info: va_openDriver() returns -1
> [00007f2110001f60] glconv_vaapi_x11 gl error: vaInitialize: unknown libva error
> libva info: VA-API version 1.1.0
> libva info: va_getDriverName() returns 0
> libva info: Trying to open /gnu/store/9hddxnv7q3q819axyw0yngzppmrgmjfi-mesa-17.3.8/lib/dri/i965_drv_video.so
> libva info: va_openDriver() returns -1
> [00007f2110001f60] glconv_vaapi_drm gl error: vaInitialize: unknown libva error
> libva info: VA-API version 1.1.0
> libva info: va_getDriverName() returns 1
> libva error: va_getDriverName() failed with operation failed,driver_name=i965
> [00007f2110001f60] glconv_vaapi_drm gl error: vaInitialize: operation failed
> Failed to open VDPAU backend libvdpau_va_gl.so: cannot open shared object file: No such file or directory
> QObject::~QObject: Timers cannot be stopped from another thread

I see the same on core-updates.  I'm not worried about it, or at least
not as worried as I am about the security issues in the old version.

I'm content to let someone else fix this up later, if anyone cares.

> I can push it on your behalf if you tell me it's ok.

Please do so.  Thanks!

      Mark

Re: Help needed to update VLC to 3.0.3 on the master branch

[Clément Lassieur]

Mark H Weaver <mhw@netris.org> writes:

>> I can push it on your behalf if you tell me it's ok.
>
> Please do so.  Thanks!

Done.  Thank you and Roel for that great work!

Clément

Re: Help needed to update VLC to 3.0.3 on the master branch

[Roel Janssen]

Mark H Weaver <mhw@netris.org> writes:

> Hello Guix,
>
> I just pushed a major VLC update to the 'core-updates' branch, commit
> 76277052939524d1ea3394f83739f06efd0dd8ae.  I pushed it to 'core-updates'
> because I've been living on that branch for months, and so it's the only
> branch that I can easily test for.
>
> However, I strongly suspect that the old VLC on master, and the old
> ffmpeg-2.8 that it depends on, are most likely a security risk.
>
> So, I would be grateful if someone could cherry-pick this commit to
> 'master', do some basic testing on it, and then push it on my behalf if
> it works.

I've had the VLC 3.0.1 commit applied on the master branch and VLC works
fine.  I only use ‘vlc’, and not ‘cvlc’.  We may have to wrap ‘cvlc’ as
well.  But we can do that at a later time if someone finds a problem.

Kind regards,
Roel Janssen