From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#31786: 'pre-inst-env guix --version' is not updated by new commits" Date: Tue, 12 Jun 2018 22:33:17 +0200 Message-ID: <87d0wvoicy.fsf@gnu.org> References: <87r2lddwyg.fsf@gmail.com> <87k1r4p2ca.fsf@gnu.org> <87k1r3271g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSpzQ-0003Z8-1O for bug-guix@gnu.org; Tue, 12 Jun 2018 16:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSpzO-0003y2-TN for bug-guix@gnu.org; Tue, 12 Jun 2018 16:34:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSpzO-0003xs-Pc for bug-guix@gnu.org; Tue, 12 Jun 2018 16:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSpzO-0007ho-II for bug-guix@gnu.org; Tue, 12 Jun 2018 16:34:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87k1r3271g.fsf@gmail.com> (George Clemmer's message of "Tue, 12 Jun 2018 14:28:43 -0400") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: George Clemmer Cc: 31786@debbugs.gnu.org George Clemmer skribis: > Ludovic Court=C3=A8s writes: > >> Hello George, >> >> George Clemmer skribis: >> >>> But with subsequent git commit/make cycles the version does not >>> change. It doesn't change when the guix package is updated either. For >>> example, after pulling and building the recent commit updating the guix >>> package ... >> >> Currently the version number is hardcoded in =E2=80=98configure.ac=E2=80= =99, so the fact >> that running =E2=80=9Cgit pull && make=E2=80=9D doesn=E2=80=99t change i= t is expected. So to >> me, it=E2=80=99s not a bug. >> >> We could improve on that (see for instance how Guile does it with >> build-aux/git-version-gen), but it still won=E2=80=99t be updated at eac= h commit >> because that=E2=80=99d be inconvenient: =E2=80=98config.h=E2=80=99 would= regenerated, so in turn >> we=E2=80=99d need to rebuild all of the C++ code. > > Hi Ludo=E2=80=99, > > Ok, cool. Thanks for the clarification. So... how about adding a > footnote to '(guix) Running Guix Before It Is Installed' something like > ... > > (3) The Guix version in the Guix build is set by './configure'. Thus, > when guix is run from the Git working tree by './pre-inst-env guix' or a > '~/.config/guix/latest=E2=80=99 symlink, the version reported by 'guix > --version' is not updated by subsequent 'git pull; make' steps. To > update the version (and rebuild everything), you may use 'git clean > -dfx; ./bootstrap; ./configure; make'. I=E2=80=99m not comfortable documenting this because it=E2=80=99s nothing s= pecific to Guix. Besides, note that ~/.config/guix/latest no longer exists. >>> 2) why don't you gitignore .po files? >> >> Because they are checked in. > > I guess I meant to say, why does the build change these checked-in > files? It seems like they should be ignored. The build changes them only if you start anew. In normal circumstances (meaning you didn=E2=80=99t run =E2=80=9Cdistclean=E2=80=9D), they remained= unchanged if I=E2=80=99m not mistaken. So yeah, it=E2=80=99s occasionally annoying, but I=E2=80=99m not sure how t= o fix this. Ludo=E2=80=99.