From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcDcQ-0002j5-Gl for guix-patches@gnu.org; Sun, 08 Jul 2018 13:37:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcDcM-0006Wj-En for guix-patches@gnu.org; Sun, 08 Jul 2018 13:37:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcDcM-0006WX-9e for guix-patches@gnu.org; Sun, 08 Jul 2018 13:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fcDcM-000434-17 for guix-patches@gnu.org; Sun, 08 Jul 2018 13:37:02 -0400 Subject: [bug#31531] [PATCH 1/3] gnu: Add cppzmq. Resent-Message-ID: References: <87bmdbtr7p.fsf@foradis.org> <20180519185437.23665-1-theodoros@foradis.org> <87vabgoimj.fsf@elephly.net> From: Theodoros Foradis In-reply-to: <87vabgoimj.fsf@elephly.net> Date: Sun, 08 Jul 2018 20:35:46 +0300 Message-ID: <87d0vxy6j1.fsf@foradis.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 31531@debbugs.gnu.org Hello Ricardo, > Could you please send a new patch? Sorry for taking so long to send the new patch. In the meantime, monero was updated to 0.12.3.0 with a major difference, that using the system's miniupnpc was disabled, and the project's own version of it (due to security issues upstream) was added as a git submodule. So, there were 3 options for us. Either build from git and use the git submodule, disregard the security issue (that the folks at #monero-dev on freenode advised against) and use our own miniupnpc, or use monero's miniupnpc. I opted for the third option, introducing a patch that reverts the git commit that does not allow to use external miniupnpc, as well as packaging monero-project's miniupnpc as a non-public package in finance.scm. Is this the correct way to do this? Also, I included a commit renaming monero-core to monero-gui, as the official project was renamed. Is this appropriate? The old url (using monero-core) still worked as it's an alias for monero-gui now, but I figured it would be better to rename nonetheless. Lastly, I changed both packages to use git-fetch, as the github auto-generated tarballs would change. What do you think? I reply to this mail with the updated patch series. -- Theodoros Foradis