From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fk4LX-0003KA-Pn for guix-patches@gnu.org; Mon, 30 Jul 2018 05:20:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fk4LT-0000FF-H8 for guix-patches@gnu.org; Mon, 30 Jul 2018 05:20:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fk4LT-0000F6-CP for guix-patches@gnu.org; Mon, 30 Jul 2018 05:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fk4LS-0001gI-BK for guix-patches@gnu.org; Mon, 30 Jul 2018 05:20:02 -0400 Subject: [bug#31999] [bug#32299] [PATCH 1/7] gnu: Add volume-key. Resent-Message-ID: References: <87r2k86x0p.fsf@fastmail.com> <20180728215835.9132-1-ambrevar@gmail.com> <87sh413ce4.fsf@fastmail.com> From: Pierre Neidhardt In-reply-to: <87sh413ce4.fsf@fastmail.com> Date: Mon, 30 Jul 2018 11:19:11 +0200 Message-ID: <87d0v513ow.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 31999@debbugs.GNU.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Pierre Neidhardt writes: > >> * gnu/package/disk.scm (volume-key): New variable. > > [...] > >> +(define-public volume-key >> + (package >> + (name "volume-key") >> + (version "0.3.10") > > 0.3.11 is out! > >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://releases.pagure.org/volume_k= ey/volume_key-" >> + version ".tar.xz")) >> + (sha256 >> + (base32 >> + "19wqgrd0cnnjs1b1d7s9ssc957vis8vj7bls9rkwhf9ywgkrswn5")= ))) >> + (build-system gnu-build-system) >> + (native-inputs >> + `(("pkg-config" ,pkg-config) >> + ("util-linux" ,util-linux) >> + ("glib" ,glib) >> + ("swig" ,swig) >> + ("lvm2" ,lvm2) >> + ("python" ,python-2))) ; Used to generate the Python b= indings. > > Are you sure lvm2 and glib are native-inputs? I.e. are they truly only > needed for building, and not at runtime? > > Other than that LGTM! > >> + (inputs >> + `(("cryptsetup" ,cryptsetup) >> + ("nss" ,nss) >> + ("gpgme" ,gpgme))) >> + (arguments >> + `(#:tests? #f ; Not sure how tests are supposed to pass, even when= run manually. >> + #:phases >> + (modify-phases %standard-phases >> + (add-before 'configure 'patch-python.h-path >> + (lambda* (#:key inputs #:allow-other-keys) >> + (let ((python (assoc-ref inputs "python"))) >> + (substitute* "Makefile.in" >> + (("/usr/include/python") (string-append python "/inclu= de/python"))) >> + #t)))))) >> + (home-page "https://pagure.io/volume_key") >> + (synopsis "Manipulate storage volume encryption keys") >> + (description >> + "This package provides a library for manipulating storage volume >> +encryption keys and storing them separately from volumes to handle forg= otten >> +passphrases.") >> + (license license:gpl2))) >> --=20 >> 2.18.0 Acknowledged. But mind the confusion with the bug number (my bad, I messed up). I'm CC'ing this answer to the right bug number. =2D-=20 Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlte2A8ACgkQm9z0l6S7 zH/+kQf/ZKmVjUAPo47m3nl0NcFIZBi7eYJXr8brosVR9g8oKVSd2pX+JbhSihJS 4xqlWL/fFB0dA58q1ZFmU5zzOx9qNaMNR2FNnPolYm2YqY/NUTD/9MxSiuR6Zeed YNM0t8cNDHX2MQJ1qH2j4DoCHWnLnIC/Y0ryYUhDq7iYHfZJVCNXOJDkKza7IF/B yQ51vO0AVrught6jzhMp0UtB8pElji6XCV4wqaM74rdekgRBWEG4samJ+pCEImL4 nakVKBX1YLD7BuEKWiVW99etP4cnQTz6m6yOk86MabZ2hASun4ilkisgiGUvBai0 kJ9Wo7+kPQ3xNGZ+Wk+Ux0OVNMrFaw== =TjJg -----END PGP SIGNATURE----- --=-=-=--