From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: Package for LXQt. Help wanted. Date: Mon, 22 Oct 2018 22:31:48 +0800 Message-ID: <87d0s2qch7.fsf@member.fsf.org> References: <87va5ushnh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEbFy-0005ZA-CM for guix-devel@gnu.org; Mon, 22 Oct 2018 10:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEbFq-0007HB-UP for guix-devel@gnu.org; Mon, 22 Oct 2018 10:32:32 -0400 Received: from rezeros.cc ([2001:19f0:7001:2f3e:5400:ff:fe84:e55d]:41440) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gEbFm-00078b-E8 for guix-devel@gnu.org; Mon, 22 Oct 2018 10:32:25 -0400 In-Reply-To: <87va5ushnh.fsf@gmail.com> (Meiyo Peng's message of "Mon, 22 Oct 2018 12:57:06 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Meiyo Peng Cc: guix-devel@gnu.org Meiyo Peng writes: > Hello everyone, > > I made a series of packages for LXQt. The code is at: > https://github.com/meiyopeng/guix/tree/lxqt Hello, it looks great! > > I did this beacuse I want to run i3 window manager within lxqt > session. Currently most things work great except lxqt-panel. I have two > problems. > > 1. The $QT_PLUGIN_PATH environment variable points to > /run/current-system/profile/lib/qt5/plugins. I don't know where it's > set. The QT_PLUGIN_PATH can be set by the 'native-search-paths' of qtbase, I guess you have qtbase in your system profile. If you install qtbase into the user profile, the variable would contains '~/.guix-profile/lib/qt5/plugins'. > So qtsvg has to be installed into syetem profile, or all the lxqt > applications can not properly display icons. Yeah, instead the system profile you can also install qtsvg, etc. into the user profile. > Should I add qtsvg to lxqt applications' propagated-inputs? If so, > should I add qtbase too, since qtbase also provides lib/qt5/plugins, > although lxqt works without qtbase in system profile but I can never > be sure. Yes, we can make them 'propagated-inputs' so that the variables can be set by the profile (via native-search-paths), or we can wrap the binaries with all the environment variables (eg: krita). > > 2. lxqt-panel complains about "Warning: Could not find any platform > plugin". (lxqt-runner also prints this message but it works.) I found > out this message was printed by kwindowsystem. > > The related code in kwindowsystem: > https://github.com/KDE/kwindowsystem/blob/9f88c9a5d25ff7909c25ce399572ca348b5706b1/src/pluginwrapper.cpp#L79 > > Qt's document (https://doc.qt.io/qt-5/qcoreapplication.html#libraryPaths) > says "entries of the QT_PLUGIN_PATH environment variable are always > added to libraryPaths". So I install kwindowsystem into system profile, > and add /run/current-system/profile/lib/plugins to QT_PLUGIN_PATH. Then > this error message disappear. But lxqt-panel still does not work. Okay, we can look into it later... > > I still have no idea how to fix lxqt-panel. This does not affect me > because I use i3, so lxqt-panel is useless to me. But there may be other > people interested in LXQt and I want to help them get this fixed. Can > anybody help me? > > Will anybody help me review the code? I'd appreciate it. Generally it look good to me, and I had cherry-pick 2 commits, and push them (hope it doesn't break existing other lxqt things...), and will look into others in next days. Some notes to you: - Wrap lines under 80 characters if possible. - Keep comments for '#:tests #f', etc. Thank you!