From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPAkb-0007oM-8D for guix-patches@gnu.org; Tue, 20 Nov 2018 13:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPAg5-0005XW-Vx for guix-patches@gnu.org; Tue, 20 Nov 2018 13:25:02 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPAfx-0005Sr-Ct for guix-patches@gnu.org; Tue, 20 Nov 2018 13:23:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPAfx-0000MM-0m for guix-patches@gnu.org; Tue, 20 Nov 2018 13:23:05 -0500 Subject: [bug#33185] [PATCH 7/7] services: Add patchwork. Resent-Message-ID: References: <20181104104455.3527-1-mail@cbaines.net> <20181104104455.3527-7-mail@cbaines.net> <87d0r1xblc.fsf@gnu.org> From: Christopher Baines In-reply-to: <87d0r1xblc.fsf@gnu.org> Date: Tue, 20 Nov 2018 18:22:03 +0000 Message-ID: <87d0qzsj78.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33185@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > swedebugia skribis: > >> On 2018-11-04 11:44, Christopher Baines wrote: >>> --- >>> gnu/services/web.scm | 297 ++++++++++++++++++++++++++++++++++++++++++- >>> gnu/tests/web.scm | 104 ++++++++++++++- >>> 2 files changed, 399 insertions(+), 2 deletions(-) >> >> Nice work with the service-declaration. :) (untested) > > +1! > >> Would you be willing to update the patch with documentation also? > > Yes, also with =E2=80=98documentation=E2=80=99 fields. :-) > > I spotted a typo here: > > +(define-record-type* > + patchwork-configuration make-patchwork-configuration > + patckwork-configuration? > ^^ Good spot! > Regarding =E2=80=98patchwork-setup-gexp=E2=80=99, I wonder if you could u= se > =E2=80=98make-forkexec-constructor=E2=80=99 with the appropriate environm= ent variables > and move the =E2=80=9Ccreateuser=E2=80=9D bit to an activation snippet. > > Hmm maybe the activation snippet would run too early, right? In that > case, perhaps you could create another Shepherd service, > =E2=80=98patchwork-initialization=E2=80=99, that would do the createuser = stuff, and have > =E2=80=98patchwork=E2=80=99 depend on it. So, I've made some changes since I last sent this patch, the biggest being splitting the database creation out from running of the database migrations. Assuming that the shepherd service defined as part of the patchwork-service-type just runs the migrations, yes, it needs PostgreSQL (or whatever database you're using) to be available. At the moment, the service is hardcoded to use mod_wsgi, so it runs through the httpd-service, no shepherd service for running patchwork is needed in the service-type at least. It would be good to try and make it more flexible in the future, at least so that you can pick and choose a bit more (and instead use uwsgi, gunicorn, ...). Thanks for taking a look :) Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKSBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlv0UMtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xcvsg/3Sand6E/rpQZ+mSeb36Mnj++b7mk02DW5Ly8s+NdEv2aSy2g83Xfjrbyk hyE3frkYLLZSjCm96CbZkLSvhEQXQPCmi7A+WlNoCtg3vDBq6PYKN9vwn/PtU5mu kdgtXXTQ2woaI5BYxUC3HATCAMGk/vXkDlRhcQPp8SDNXzgCGWEOPo8zfGrVxK8p LnXG6wHU1XSMe32AVP36pJESQhd4PdvNv+/d8HHXyeK8XRbL5pus8TZLhbl0Xaep A4ffkmGlh6HzHT6eg6HgIpC/mQbZjQG4Qd3oOCKtzcV4YGEbuiSijOVOHIe4oPdy kbGVmlLqJPamCkDgAxsmshtt9TLXjNnkMYel69b/NEoPMpUiM2aHMRN1zS4a9Z2V 6kadfJwORGFM8bThg1pqmOkPM0UPpXY+jvVgFk8FWFiTp0RvvJOqoHveliwAwvrN H/cV+strqk/foDZKOQzyhnVKl4BkbWanwNI0Qz8qLVM2QEPxggASXYTZerdRfocL mdmsEHOhpkk1f/OCsSatPsOJvdh0QBPamE6j42ehpOhZqzfnKNfUm4bJhkRbJWNI CydNiyJDvX5jlVt8aD+zmoPH43TsDnaqFC+MNyaifAmr/iufVJAEW7fVh3ON03qA cbLe/chE8TEhvK78XNGq2TdnF9r0/TPNaUh31mVzYFEqo63a7A== =9ElR -----END PGP SIGNATURE----- --=-=-=--