From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmUkQ-0007lt-HV for guix-patches@gnu.org; Wed, 23 Jan 2019 21:28:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmUkO-0004CP-K8 for guix-patches@gnu.org; Wed, 23 Jan 2019 21:28:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmUkM-00046L-OH for guix-patches@gnu.org; Wed, 23 Jan 2019 21:28:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gmUkM-0003lo-93 for guix-patches@gnu.org; Wed, 23 Jan 2019 21:28:02 -0500 Subject: [bug#34137] [PATCH] gnu: Add ghc-libmp. Resent-Message-ID: From: Timothy Sample References: <878szgv0tw.fsf@gmail.com> <87ef978fco.fsf@ngyro.com> <874la2v4et.fsf@gmail.com> Date: Wed, 23 Jan 2019 21:27:42 -0500 In-Reply-To: <874la2v4et.fsf@gmail.com> (Gabriel Hondet's message of "Mon, 21 Jan 2019 08:46:50 +0100") Message-ID: <87d0omzt5t.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Gabriel Hondet Cc: 34137@debbugs.gnu.org Hi Gabriel, Gabriel Hondet writes: > Hi Timothy, > > On Sun 20 Jan 2019 at 17:26 Timothy Sample wrote: > >> You should be able to remove the =E2=80=9Cghc-mtl=E2=80=9D input from th= e MPD package >> without any issue. > > Indeed and it works even better, so here is the new patch: Glad to hear it. I checked the ghc-libmpd package, and have a few notes (in addition to what Ludo said about moving it). > * gnu/packages/mpd.scm (ghc-libmpd): New variable. > --- > gnu/packages/mpd.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm > index 3fe5d06f4..df4f64470 100644 > --- a/gnu/packages/mpd.scm > +++ b/gnu/packages/mpd.scm > @@ -6,6 +6,7 @@ > ;;; Copyright =C2=A9 2015 Paul van der Walt > ;;; Copyright =C2=A9 2016, 2018 Leo Famulari > ;;; Copyright =C2=A9 2018 Tobias Geerinckx-Rice > +;;; Copyright =C2=A9 2019 Gabriel Hondet > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -31,6 +32,7 @@ > #:use-module (guix build-system gnu) > #:use-module (guix build-system meson) > #:use-module (guix build-system python) > + #:use-module (guix build-system haskell) > #:use-module (gnu packages avahi) > #:use-module (gnu packages boost) > #:use-module (gnu packages gcc) > @@ -51,6 +53,8 @@ > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages python) > #:use-module (gnu packages python-xyz) > + #:use-module (gnu packages haskell) > + #:use-module (gnu packages haskell-check) > #:use-module (gnu packages pulseaudio) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages video) > @@ -360,3 +364,34 @@ Daemon (MPD). It supports playlists, multiple profi= les (connecting to different > MPD servers, search and multimedia key support.") > (home-page "https://www.nongnu.org/sonata/") > (license license:gpl3+))) > + > +(define-public ghc-libmpd > + (package > + (name "ghc-libmpd") > + (version "0.9.0.9") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://hackage.haskell.org/package/libmpd/libmpd-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "1931m23iqb4wddpdidm4ph746zpaw41kkjzmb074j7yyfpk7x1jv")))) > + (build-system haskell-build-system) > + (inputs > + `(("ghc-attoparsec" ,ghc-attoparsec) > + ("ghc-old-locale" ,ghc-old-locale) > + ("ghc-text" ,ghc-text) > + ("ghc-data-default-class" ,ghc-data-default-class) > + ("ghc-network" ,ghc-network) > + ("ghc-utf8-string" ,ghc-utf8-string))) > + (native-inputs > + `(("ghc-quickcheck" ,ghc-quickcheck) > + ("ghc-hspec" ,ghc-hspec) > + ("hspec-discover" ,hspec-discover))) > + (home-page "http://github.com/vimus/libmpd-haskell#readme") Maybe drop the anchor here (the =E2=80=9C#readme=E2=80=9D part). The linte= r complains about it, and I don=E2=80=99t think it adds much. > + (synopsis "MPD client library") This might be better if it mentions Haskell and spells out the initialism: =E2=80=9CHaskell client library for the Music Player Daemon (MP= D)=E2=80=9D. > + (description "A client library for MPD, the Music Player Daemon.") We try to use complete sentences in the description. Often, you just need to add the words =E2=80=9Cthis package provides=E2=80=9D to the beginn= ing. For this, I might write: This package provides a pure Haskell client library for the Music Player Daemon (MPD). > + (license license:expat))) Other than that it looks good! -- Tim