From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:41157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwYg2-0007k4-NC
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:41:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwYfw-0008Q9-Vz
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:41:08 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57836)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gwYfv-0008Dm-Nk
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:41:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwYfu-0003t0-IN
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:41:02 -0500
Subject: bug#34592: [PATCH] gnu: python-fenics-dijitso: Fix build.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.34592.D34592.155069523714865.done@debbugs.gnu.org>
References: <1550664967-441-1-git-send-email-pgarlick@tourbillion-technology.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <1550664967-441-1-git-send-email-pgarlick@tourbillion-technology.com>
Date: Wed, 20 Feb 2019 21:40:08 +0100
Message-ID: <87d0nm5h3r.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 34592-done@debbugs.gnu.org


Paul Garlick <pgarlick@tourbillion-technology.com> writes:

> * gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
> parallel tests.
> ---
>  gnu/packages/simulation.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index 20b62f3..3637cc3 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
>               (setenv "PYTHONPATH"
>                       (string-append (getcwd) ":" (getenv "PYTHONPATH")))
>               (with-directory-excursion "test"
> +               ;; Disable parallel tests to avoid race condition.  See
> +               ;; https://github.com/pytest-dev/pytest-cov/issues/237.
> +               (substitute* "runtests.sh"
> +                 (("for p in 1 4 8 16; do")
> +                  "for p in 1; do"))
>                 (invoke "./runtests.sh"))
>               #t)))))
>      (home-page "https://bitbucket.org/fenics-project/dijitso/")

I wondered if we could use the #:parallel-tests? argument instead, but
the python-build-system does not support it.  This approach looks fine
to me.

Thanks!

I pushed it to the master branch with commit 7a82074ca6.

--
Ricardo