all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 34592-done@debbugs.gnu.org
Subject: bug#34592: [PATCH] gnu: python-fenics-dijitso: Fix build.
Date: Wed, 20 Feb 2019 21:40:08 +0100	[thread overview]
Message-ID: <87d0nm5h3r.fsf@elephly.net> (raw)
In-Reply-To: <1550664967-441-1-git-send-email-pgarlick@tourbillion-technology.com>


Paul Garlick <pgarlick@tourbillion-technology.com> writes:

> * gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
> parallel tests.
> ---
>  gnu/packages/simulation.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index 20b62f3..3637cc3 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
>               (setenv "PYTHONPATH"
>                       (string-append (getcwd) ":" (getenv "PYTHONPATH")))
>               (with-directory-excursion "test"
> +               ;; Disable parallel tests to avoid race condition.  See
> +               ;; https://github.com/pytest-dev/pytest-cov/issues/237.
> +               (substitute* "runtests.sh"
> +                 (("for p in 1 4 8 16; do")
> +                  "for p in 1; do"))
>                 (invoke "./runtests.sh"))
>               #t)))))
>      (home-page "https://bitbucket.org/fenics-project/dijitso/")

I wondered if we could use the #:parallel-tests? argument instead, but
the python-build-system does not support it.  This approach looks fine
to me.

Thanks!

I pushed it to the master branch with commit 7a82074ca6.

--
Ricardo

      reply	other threads:[~2019-02-20 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 12:16 [bug#34592] [PATCH] gnu: python-fenics-dijitso: Fix build Paul Garlick
2019-02-20 20:40 ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0nm5h3r.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=34592-done@debbugs.gnu.org \
    --cc=pgarlick@tourbillion-technology.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.