From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0lMC-0007Dr-18 for guix-patches@gnu.org; Mon, 04 Mar 2019 06:02:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0lMA-00035G-Vj for guix-patches@gnu.org; Mon, 04 Mar 2019 06:02:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0lMA-00033y-Cp for guix-patches@gnu.org; Mon, 04 Mar 2019 06:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h0lMA-0005uD-4M for guix-patches@gnu.org; Mon, 04 Mar 2019 06:02:02 -0500 Subject: [bug#34486] [PATCH 0/1] Add '--inherit' to 'guix environment' Resent-Message-ID: References: <20190215104257.16275-1-ludo@gnu.org> <20190216102325.3875f22b@centurylink.net> <87ef82tmxw.fsf@elephly.net> <87tvgjt0eu.fsf@gnu.org> From: Ricardo Wurmus In-reply-to: <87tvgjt0eu.fsf@gnu.org> Date: Mon, 04 Mar 2019 12:01:02 +0100 Message-ID: <87d0n6x5sh.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34486@debbugs.gnu.org, Eric Bavier Ludovic Court=C3=A8s writes: > Hi! > > Ricardo Wurmus skribis: > >> Eric Bavier writes: >>> I wonder if the word "inherit" here might be too easily confused with >>> the idea of package inheritance. Could we possibly use an option name >>> that is familiar? Of-hand I'm thinking of sudo's '-E' and >>> '--preserve-env'. SLURM itself uses '--export'. Both of these tools >>> requires passing a list of individual environment variables, but >>> supporting regexp-matching makes sense to me, especially with the SLURM >>> use-case in mind. >> >> I think =E2=80=9Cexport=E2=80=9D is a worse name, especially in combinat= ion with =E2=80=9Cguix >> environment=E2=80=9D, which sounds like the Guix environment is to be ex= ported. >> >> =E2=80=9Cpreserve=E2=80=9D sounds good to me, but it=E2=80=99s also a ch= aracter longer than >> =E2=80=9Cinherit=E2=80=9D ;) >> >> I=E2=80=99m not a big fan of =E2=80=9Cinherit=E2=80=9D because to me it = seems to imply that the >> existing environment is to be inherited fully, while the actual intent >> is to keep only the selected variables. >> >> =E2=80=9Ckeep=E2=80=9D or =E2=80=9Callow=E2=80=9D sound also good to me. > > So, what about adding =E2=80=98--preserve=E2=80=99 (or =E2=80=98--keep=E2= =80=99? I slightly prefer > =E2=80=9Cpreserve=E2=80=9D) and keeping =E2=80=98--inherit=E2=80=99 as a = deprecated alias? Sounds good to me, though in my opinion =E2=80=9C--inherit=E2=80=9D hasn=E2= =80=99t been around long enough to warrant deprecation. > We could perhaps add =E2=80=98-E=E2=80=99 as well, reclaiming the long-de= precated > =E2=80=98--exec=E2=80=99, WDYT? --preserve/-E would be equivalent? -- Ricardo